Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Development: Shorten e2e test duration #6833

Merged
merged 6 commits into from
Jul 15, 2023
Merged

Conversation

TheZoker
Copy link
Contributor

@TheZoker TheZoker commented Jul 6, 2023

Checklist

General

Motivation and Context

E2E tests take about 85 minutes and we want to reduce that run time

Description

This PR reduces the runtime of the E2E test by almost 20 minutes by changing the following:

  • Use shorter text inputs for most text exercises and communication tests
  • Input the programming exercise code directly instead of typing it (this will also add support for other programming languages in the future 🎉)

Review Progress

Code Review

  • Review 1
  • Review 2

@TheZoker TheZoker requested a review from a team as a code owner July 6, 2023 08:56
@github-actions github-actions bot added tests cypress Pull requests that update cypress tests. (Added Automatically!) labels Jul 6, 2023
@TheZoker TheZoker force-pushed the test/cypress/enhance-runtime branch from b220599 to 9f5d97d Compare July 6, 2023 09:33
@4ludwig4
Copy link
Contributor

Code looks good to me, Tests are indeed about 15-20 minutes shorter. I guess you'll resolve the conflicts then no problem from my side to approve it!

# Conflicts:
#	src/test/cypress/e2e/course/CourseCommunication.cy.ts
@krusche krusche changed the title Development: Enhance E2E test runtime Development: Shorten e2e test duration Jul 15, 2023
@krusche krusche added this to the 6.3.4 milestone Jul 15, 2023
@krusche krusche merged commit a2db3f2 into develop Jul 15, 2023
25 of 27 checks passed
@krusche krusche deleted the test/cypress/enhance-runtime branch July 15, 2023 12:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cypress Pull requests that update cypress tests. (Added Automatically!) priority:high ready for review tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants