-
Notifications
You must be signed in to change notification settings - Fork 291
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Development
: Delete old files properly when updating file submissions
#6849
Conversation
Co-authored-by: Johannes Stöhr <[email protected]>
…stead of the fileUploadSubmission parameter.
80022be
src/main/java/de/tum/in/www1/artemis/service/FileUploadSubmissionService.java
Dismissed
Show dismissed
Hide dismissed
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The server style action is currently failing, please run spotlessApply
to fix the reported issues.
src/main/java/de/tum/in/www1/artemis/service/FileUploadSubmissionService.java
Outdated
Show resolved
Hide resolved
Development
: Load participation from DB with file-upload submissionsDevelopment
: Use participation from DB with file-upload submissions
Development
: Use participation from DB with file-upload submissionsDevelopment
: Use participation to get file-upload submissions from DB
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reapprove
Development
: Use participation to get file-upload submissions from DBDevelopment
: Delete old files properly when updating file submissions
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code looks good to me and makes sense 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
reapprove
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
code looks good.
Checklist
General
Server
Motivation and Context
The parameter fileUploadSubmission is currently getting used for getting the last submission in FileUploadSubmissionService. The data of this parameter is under the control of the user, which may pose certain risks.
Description
Instead of FileUploadSubmission fileUploadSubmission, we now use StudentParticipation participation for getting the last submission in FileUploadSubmissionService, as the data of this parameter is not under the control of the user.
Steps for Testing
We just want to make sure that I didn't accidentally break the implementation.
Prerequisites:
Fileupload Exercise (Instructor, Student):
Review Progress
Performance Review
Code Review
Manual Tests
Test Coverage