Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lectures: Allow sorting of lectures in the course management #6850

Conversation

basak-akan
Copy link
Contributor

@basak-akan basak-akan commented Jul 7, 2023

Checklist

General

Client

  • Important: I implemented the changes with a very good performance, prevented too many (unnecessary) REST calls and made sure the UI is responsive, even with large data.
  • I followed the coding and design guidelines.
  • I added multiple screenshots/screencasts of my UI changes.

Motivation and Context

Resolves #6439
This feature would make it easier for users to find specific lectures, especially in courses with a large number of lectures. The sorting feature would enhance the user experience by providing a more organized view of lectures.

Description

A lecture sorting feature is added in the course management section of Artemis. This feature allows users to sort lectures based on different criteria such as id, title, description, visible from, start, and end date.

  • Alphabetical sorting for string values adapted into existing sort service
  • Course column removed

Steps for Testing

Prerequisites:

  • 1 Instructor/Admin/Editor/TA (who has access to course management)
  • Course which has multiple lectures
  1. Log in to Artemis
  2. Navigate to Course Management
  3. Navigate Lectures
  4. Verify sorting lectures by id, title, description, visible from, start, and end date possible.

Review Progress

Performance Review

  • I confirm that the client changes (in particular related to REST calls and UI responsiveness) are implemented with a very good performance

Code Review

  • Code Review 1
  • Code Review 2

Manual Tests

  • Test 1
  • Test 2

Test Coverage

Client

Class/File Line Coverage Confirmation (assert/expect)
lecture.component.ts 96.47%

Screenshots

sort_lecture_v3

@github-actions github-actions bot added tests client Pull requests that update TypeScript code. (Added Automatically!) labels Jul 7, 2023
@basak-akan basak-akan marked this pull request as ready for review July 10, 2023 17:09
@basak-akan basak-akan requested a review from a team as a code owner July 10, 2023 17:09
Copy link
Contributor

@terlan98 terlan98 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes look good. I have one comment regarding the new test 🙂

@github-actions
Copy link

❌ Unable to deploy to test servers ❌

Testserver "artemis-test6.artemis.cit.tum.de" is already in use by PR #6760.

@github-actions github-actions bot added the deployment-error Added by deployment workflows if an error occured label Jul 10, 2023
@SolizerCodes SolizerCodes added deploy:artemis-test5 and removed deployment-error Added by deployment workflows if an error occured labels Jul 10, 2023
@SolizerCodes SolizerCodes temporarily deployed to artemis-test5.artemis.cit.tum.de July 10, 2023 21:28 — with GitHub Actions Inactive
Copy link
Contributor

@JohannesStoehr JohannesStoehr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good to me

Copy link
Contributor

@terlan98 terlan98 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code

Copy link
Member

@julian-christl julian-christl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the changes, code looks great. Also quickly tested on TS1

@julian-christl
Copy link
Member

julian-christl commented Jul 21, 2023

I suggest changing the title to Lectures. Not sure what it has to do with Assesssment.

=> "Lectures: Allow sorting in the course management"

@basak-akan basak-akan changed the title Assessment: Allow sorting of lectures in the course management Lectures: Allow sorting of lectures in the course management Jul 21, 2023
Copy link
Contributor

@Strohgelaender Strohgelaender left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code looks good

Copy link
Contributor

@laadvo laadvo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested on ts1, lectures can get sorted by different criteria as expected. Useful feature :)

@krusche krusche merged commit 1851c04 into develop Aug 2, 2023
25 of 27 checks passed
@krusche krusche deleted the feature/6439-allow-sorting-of-lectures-in-the-course-management branch August 2, 2023 19:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
client Pull requests that update TypeScript code. (Added Automatically!) ready to merge tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow sorting of lectures in the course management