-
Notifications
You must be signed in to change notification settings - Fork 291
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Lectures
: Allow sorting of lectures in the course management
#6850
Lectures
: Allow sorting of lectures in the course management
#6850
Conversation
…-the-course-management
…-the-course-management
…-the-course-management
…-the-course-management
…-the-course-management
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The changes look good. I have one comment regarding the new test 🙂
src/test/javascript/spec/component/lecture/lecture.component.spec.ts
Outdated
Show resolved
Hide resolved
…-the-course-management
❌ Unable to deploy to test servers ❌Testserver "artemis-test6.artemis.cit.tum.de" is already in use by PR #6760. |
bd113ac
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code looks good to me
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for the changes, code looks great. Also quickly tested on TS1
I suggest changing the title to => " |
Assessment
: Allow sorting of lectures in the course managementLectures
: Allow sorting of lectures in the course management
…-the-course-management
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
code looks good
…-the-course-management
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested on ts1, lectures can get sorted by different criteria as expected. Useful feature :)
…-the-course-management
…-the-course-management
…-the-course-management
Checklist
General
Client
Motivation and Context
Resolves #6439
This feature would make it easier for users to find specific lectures, especially in courses with a large number of lectures. The sorting feature would enhance the user experience by providing a more organized view of lectures.
Description
A lecture sorting feature is added in the course management section of Artemis. This feature allows users to sort lectures based on different criteria such as id, title, description, visible from, start, and end date.
Steps for Testing
Prerequisites:
Review Progress
Performance Review
Code Review
Manual Tests
Test Coverage
Client
Screenshots