Exam mode: Visualize student submissions in exam timeline
#6882
Teamscale
This pull request would introduce 31 new findings
Details
- src/test/java/de/tum/in/www1/artemis/util/HestiaUtilTestService.java#122: Clone with 2 instances of length 12 (view in Teamscale)
- src/test/java/de/tum/in/www1/artemis/exercise/programmingexercise/RepositoryIntegrationTest.java#54: Star import of
de.tum.in.www1.artemis.domain.plagiarism.*should not be used (view in Teamscale) - src/main/java/de/tum/in/www1/artemis/repository/SubmissionVersionRepository.java#32: Interface comment missing (view in Teamscale)
- src/test/java/de/tum/in/www1/artemis/util/HestiaUtilTestService.java#26: Star import of
de.tum.in.www1.artemis.repository.*should not be used (view in Teamscale) - src/test/java/de/tum/in/www1/artemis/util/HestiaUtilTestService.java#198: Interface comment missing (view in Teamscale)
- src/test/java/de/tum/in/www1/artemis/participation/SubmissionIntegrationTest.java#21: Star import of
de.tum.in.www1.artemis.repository.*should not be used (view in Teamscale) - src/test/java/de/tum/in/www1/artemis/util/HestiaUtilTestService.java#21: Star import of
de.tum.in.www1.artemis.domain.*should not be used (view in Teamscale) - src/test/java/de/tum/in/www1/artemis/exercise/programmingexercise/ProgrammingExerciseIntegrationBambooBitbucketJiraTest.java#1077: Clone with 2 instances of length 10 (view in Teamscale)
- src/test/java/de/tum/in/www1/artemis/participation/SubmissionIntegrationTest.java#213: Method
testGetSubmissionVersionsBySubmissionIdForTextExercise_returnsCorrectContentviolates naming convention. Should be one of[a-z][a-zA-Z0-9]*(view in Teamscale) - src/test/java/de/tum/in/www1/artemis/util/HestiaUtilTestService.java#248: Clone with 3 instances of length 17 (view in Teamscale)
- src/test/java/de/tum/in/www1/artemis/exercise/programmingexercise/ProgrammingExerciseIntegrationBambooBitbucketJiraTest.java#1067: Catch clause catches generic exception
Exception(view in Teamscale) - src/main/java/de/tum/in/www1/artemis/repository/ProgrammingExerciseRepository.java#231: Interface comment missing (view in Teamscale)
- src/main/java/de/tum/in/www1/artemis/web/rest/dto/ProgrammingExerciseGitDiffEntryDTO.java#21: Interface comment missing (view in Teamscale)
- src/test/java/de/tum/in/www1/artemis/exercise/programmingexercise/GitServiceTest.java#117: Avoid disabled JUnit tests (view in Teamscale)
- src/main/java/de/tum/in/www1/artemis/web/rest/hestia/ProgrammingExerciseGitDiffReportResource.java#9: Star import of
org.springframework.web.bind.annotation.*should not be used (view in Teamscale) - src/test/java/de/tum/in/www1/artemis/participation/SubmissionIntegrationTest.java#232: Method
testGetSubmissionVersionsBySubmissionId_submissionNotFoundviolates naming convention. Should be one of[a-z][a-zA-Z0-9]*(view in Teamscale) - src/main/java/de/tum/in/www1/artemis/service/hestia/ProgrammingExerciseGitDiffReportService.java#24: Star import of
de.tum.in.www1.artemis.domain.*should not be used (view in Teamscale) - src/test/java/de/tum/in/www1/artemis/util/HestiaUtilTestService.java#202: Interface comment missing (view in Teamscale)
- src/test/java/de/tum/in/www1/artemis/participation/SubmissionIntegrationTest.java#200: Method
testGetSubmissionVersionsBySubmissionId_isNotInstructorInCourse_forbiddenviolates naming convention. Should be one of[a-z][a-zA-Z0-9]*(view in Teamscale) - src/main/java/de/tum/in/www1/artemis/service/hestia/ProgrammingExerciseGitDiffReportService.java#1: Violation of file size threshold (source lines of code) of 300: 331 (view in Teamscale)
- src/main/java/de/tum/in/www1/artemis/web/rest/SubmissionResource.java#24: Star import of
de.tum.in.www1.artemis.web.rest.dto.*should not be used (view in Teamscale) - src/test/java/de/tum/in/www1/artemis/util/GitUtilService.java#197: Interface comment missing (view in Teamscale)
- src/test/java/de/tum/in/www1/artemis/util/HestiaUtilTestService.java#147: Clone with 3 instances of length 17 (view in Teamscale)
- src/main/java/de/tum/in/www1/artemis/service/connectors/GitService.java#1407: Interface comment missing (view in Teamscale)
- src/test/java/de/tum/in/www1/artemis/exercise/programmingexercise/GitServiceTest.java#24: Star import of
org.junit.jupiter.api.*should not be used (view in Teamscale) - src/main/java/de/tum/in/www1/artemis/web/rest/dto/ProgrammingExerciseGitDiffReportDTO.java#18: Interface comment missing (view in Teamscale)
- src/test/java/de/tum/in/www1/artemis/exercise/programmingexercise/ProgrammingExerciseIntegrationBambooBitbucketJiraTest.java#1086: Catch clause catches generic exception
Exception(view in Teamscale) - src/test/java/de/tum/in/www1/artemis/assessment/ResultServiceIntegrationTest.java#8: Star import of
java.util.*should not be used (view in Teamscale) - src/main/java/de/tum/in/www1/artemis/repository/SubmissionRepository.java#444: Interface comment missing (view in Teamscale)
- src/test/java/de/tum/in/www1/artemis/util/HestiaUtilTestService.java#183: Clone with 2 instances of length 12 (view in Teamscale)
- src/test/java/de/tum/in/www1/artemis/exercise/programmingexercise/ProgrammingExerciseIntegrationBambooBitbucketJiraTest.java#1059: Clone with 2 instances of length 10 (view in Teamscale)
Annotations
Check warning on line 202 in src/test/java/de/tum/in/www1/artemis/util/HestiaUtilTestService.java
teamscale / teamscale-findings
src/test/java/de/tum/in/www1/artemis/util/HestiaUtilTestService.java#L202
Interface comment missing
https://teamscale.io/findings.html#details/GitHub-ls1intum-Artemis?t=feature%2Fexam-timeline%3AHEAD&id=409E4277C2B2CAD21E3466001AAFA1EF
Check warning on line 282 in src/test/java/de/tum/in/www1/artemis/util/HestiaUtilTestService.java
teamscale / teamscale-findings
src/test/java/de/tum/in/www1/artemis/util/HestiaUtilTestService.java#L248-L282
Clone with 3 instances of length 17
https://teamscale.io/findings.html#details/GitHub-ls1intum-Artemis?t=feature%2Fexam-timeline%3AHEAD&id=4300A6D166B7EAEBF0D80FD7FD26198A
Check warning on line 198 in src/test/java/de/tum/in/www1/artemis/util/HestiaUtilTestService.java
teamscale / teamscale-findings
src/test/java/de/tum/in/www1/artemis/util/HestiaUtilTestService.java#L198
Interface comment missing
https://teamscale.io/findings.html#details/GitHub-ls1intum-Artemis?t=feature%2Fexam-timeline%3AHEAD&id=444FBE1D52A3111F2D8380B6AF117478
Check warning on line 26 in src/test/java/de/tum/in/www1/artemis/util/HestiaUtilTestService.java
teamscale / teamscale-findings
src/test/java/de/tum/in/www1/artemis/util/HestiaUtilTestService.java#L26
Star import of `de.tum.in.www1.artemis.repository.*` should not be used
https://teamscale.io/findings.html#details/GitHub-ls1intum-Artemis?t=feature%2Fexam-timeline%3AHEAD&id=4B9D20B734FEE558674C9ACA5311D38C
Check warning on line 135 in src/test/java/de/tum/in/www1/artemis/util/HestiaUtilTestService.java
teamscale / teamscale-findings
src/test/java/de/tum/in/www1/artemis/util/HestiaUtilTestService.java#L122-L135
Clone with 2 instances of length 12
https://teamscale.io/findings.html#details/GitHub-ls1intum-Artemis?t=feature%2Fexam-timeline%3AHEAD&id=593FF4C51242CF26550EA13473A327C0
Check warning on line 21 in src/test/java/de/tum/in/www1/artemis/util/HestiaUtilTestService.java
teamscale / teamscale-findings
src/test/java/de/tum/in/www1/artemis/util/HestiaUtilTestService.java#L21
Star import of `de.tum.in.www1.artemis.domain.*` should not be used
https://teamscale.io/findings.html#details/GitHub-ls1intum-Artemis?t=feature%2Fexam-timeline%3AHEAD&id=9672C694D975346C34BE0271FA3DB1C8
Check warning on line 181 in src/test/java/de/tum/in/www1/artemis/util/HestiaUtilTestService.java
teamscale / teamscale-findings
src/test/java/de/tum/in/www1/artemis/util/HestiaUtilTestService.java#L147-L181
Clone with 3 instances of length 17
https://teamscale.io/findings.html#details/GitHub-ls1intum-Artemis?t=feature%2Fexam-timeline%3AHEAD&id=C466DD770E22098D8CDF345C20231A31
Check warning on line 195 in src/test/java/de/tum/in/www1/artemis/util/HestiaUtilTestService.java
teamscale / teamscale-findings
src/test/java/de/tum/in/www1/artemis/util/HestiaUtilTestService.java#L183-L195
Clone with 2 instances of length 12
https://teamscale.io/findings.html#details/GitHub-ls1intum-Artemis?t=feature%2Fexam-timeline%3AHEAD&id=C663BDC894210979325416D4AFA8D2A6
teamscale / teamscale-findings
src/test/java/de/tum/in/www1/artemis/exercise/programmingexercise/RepositoryIntegrationTest.java#L54
Star import of `de.tum.in.www1.artemis.domain.plagiarism.*` should not be used
https://teamscale.io/findings.html#details/GitHub-ls1intum-Artemis?t=feature%2Fexam-timeline%3AHEAD&id=B63B69E8691CD666C867CDB2D9E3A2DD
teamscale / teamscale-findings
src/main/java/de/tum/in/www1/artemis/repository/SubmissionVersionRepository.java#L32
Interface comment missing
https://teamscale.io/findings.html#details/GitHub-ls1intum-Artemis?t=feature%2Fexam-timeline%3AHEAD&id=A7515E58E5F8E87F42BD30BD088ABA40
teamscale / teamscale-findings
src/test/java/de/tum/in/www1/artemis/participation/SubmissionIntegrationTest.java#L21
Star import of `de.tum.in.www1.artemis.repository.*` should not be used
https://teamscale.io/findings.html#details/GitHub-ls1intum-Artemis?t=feature%2Fexam-timeline%3AHEAD&id=0CF3073AE716F6A9BA1516C460C98611
teamscale / teamscale-findings
src/test/java/de/tum/in/www1/artemis/participation/SubmissionIntegrationTest.java#L213
Method `testGetSubmissionVersionsBySubmissionIdForTextExercise_returnsCorrectContent` violates naming convention. Should be one of `[a-z][a-zA-Z0-9]*`
https://teamscale.io/findings.html#details/GitHub-ls1intum-Artemis?t=feature%2Fexam-timeline%3AHEAD&id=1778015C82538015C7274EFCE8BDC195
teamscale / teamscale-findings
src/test/java/de/tum/in/www1/artemis/participation/SubmissionIntegrationTest.java#L232
Method `testGetSubmissionVersionsBySubmissionId_submissionNotFound` violates naming convention. Should be one of `[a-z][a-zA-Z0-9]*`
https://teamscale.io/findings.html#details/GitHub-ls1intum-Artemis?t=feature%2Fexam-timeline%3AHEAD&id=538B3F7CC2C83FD0290B31882E2906DF
teamscale / teamscale-findings
src/test/java/de/tum/in/www1/artemis/participation/SubmissionIntegrationTest.java#L200
Method `testGetSubmissionVersionsBySubmissionId_isNotInstructorInCourse_forbidden` violates naming convention. Should be one of `[a-z][a-zA-Z0-9]*`
https://teamscale.io/findings.html#details/GitHub-ls1intum-Artemis?t=feature%2Fexam-timeline%3AHEAD&id=ADFA0F79C7F73B47152B5CAB4F77E941
teamscale / teamscale-findings
src/test/java/de/tum/in/www1/artemis/exercise/programmingexercise/ProgrammingExerciseIntegrationBambooBitbucketJiraTest.java#L1067-L1069
Catch clause catches generic exception `Exception`
https://teamscale.io/findings.html#details/GitHub-ls1intum-Artemis?t=feature%2Fexam-timeline%3AHEAD&id=231E1FD2DC5C13462E110AED37A6AB68
teamscale / teamscale-findings
src/test/java/de/tum/in/www1/artemis/exercise/programmingexercise/ProgrammingExerciseIntegrationBambooBitbucketJiraTest.java#L1086-L1088
Catch clause catches generic exception `Exception`
https://teamscale.io/findings.html#details/GitHub-ls1intum-Artemis?t=feature%2Fexam-timeline%3AHEAD&id=48A6153CA5D6E27124E6E3FC8B6A864C
teamscale / teamscale-findings
src/test/java/de/tum/in/www1/artemis/exercise/programmingexercise/ProgrammingExerciseIntegrationBambooBitbucketJiraTest.java#L1077-L1092
Clone with 2 instances of length 10
https://teamscale.io/findings.html#details/GitHub-ls1intum-Artemis?t=feature%2Fexam-timeline%3AHEAD&id=8675A67790D0212395F941F1B03B02F1
teamscale / teamscale-findings
src/test/java/de/tum/in/www1/artemis/exercise/programmingexercise/ProgrammingExerciseIntegrationBambooBitbucketJiraTest.java#L1059-L1073
Clone with 2 instances of length 10
https://teamscale.io/findings.html#details/GitHub-ls1intum-Artemis?t=feature%2Fexam-timeline%3AHEAD&id=942493A9B7EC12C2143CF52205916CE6
teamscale / teamscale-findings
src/main/java/de/tum/in/www1/artemis/repository/ProgrammingExerciseRepository.java#L231
In this file 35 interface comments are missing. Consider adding explanatory comments or restricting the visibility.
View in Teamscale:
https://teamscale.io/activity.html#details/GitHub-ls1intum-Artemis?t=feature%2Fexam-timeline%3A1697620312000
teamscale / teamscale-findings
src/main/java/de/tum/in/www1/artemis/web/rest/dto/ProgrammingExerciseGitDiffEntryDTO.java#L21
Interface comment missing
https://teamscale.io/findings.html#details/GitHub-ls1intum-Artemis?t=feature%2Fexam-timeline%3AHEAD&id=C5157FA0F9B505B0CF07F6DA84052D58
teamscale / teamscale-findings
src/test/java/de/tum/in/www1/artemis/exercise/programmingexercise/GitServiceTest.java#L117
Avoid disabled JUnit tests
https://teamscale.io/findings.html#details/GitHub-ls1intum-Artemis?t=feature%2Fexam-timeline%3AHEAD&id=E05A47A1CEDE599DADD18356EA0C210E
teamscale / teamscale-findings
src/test/java/de/tum/in/www1/artemis/exercise/programmingexercise/GitServiceTest.java#L24
Star import of `org.junit.jupiter.api.*` should not be used
https://teamscale.io/findings.html#details/GitHub-ls1intum-Artemis?t=feature%2Fexam-timeline%3AHEAD&id=FB736508D74402E6E8895F14B7AEE751
teamscale / teamscale-findings
src/main/java/de/tum/in/www1/artemis/web/rest/hestia/ProgrammingExerciseGitDiffReportResource.java#L9
Star import of `org.springframework.web.bind.annotation.*` should not be used
https://teamscale.io/findings.html#details/GitHub-ls1intum-Artemis?t=feature%2Fexam-timeline%3AHEAD&id=C74C974C0125AD5C6F461E3D3A1CDB0F
teamscale / teamscale-findings
src/main/java/de/tum/in/www1/artemis/service/hestia/ProgrammingExerciseGitDiffReportService.java#L1
Violation of file size threshold (source lines of code) of 300: 331
https://teamscale.io/findings.html#details/GitHub-ls1intum-Artemis?t=feature%2Fexam-timeline%3AHEAD&id=83C4DAB563059D28BC4C0C2BBD8AC668
teamscale / teamscale-findings
src/main/java/de/tum/in/www1/artemis/service/hestia/ProgrammingExerciseGitDiffReportService.java#L24
Star import of `de.tum.in.www1.artemis.domain.*` should not be used
https://teamscale.io/findings.html#details/GitHub-ls1intum-Artemis?t=feature%2Fexam-timeline%3AHEAD&id=9E093CE19835E6BC76EB5651E9B696DB