Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Iris: Get offered models from Pyris #6886

Merged
merged 14 commits into from
Jul 18, 2023

Conversation

SolizerCodes
Copy link

@SolizerCodes SolizerCodes commented Jul 12, 2023

Checklist

General

Server

  • Important: I implemented the changes with a very good performance and prevented too many (unnecessary) database calls.
  • I followed the coding and design guidelines.
  • I added pre-authorization annotations according to the guidelines and checked the course groups for all new REST Calls (security).
  • I documented the Java code using JavaDoc style.

Motivation, Context and Description

Since introducing a health endpoint to Pyris, we also want to provide a dynamic model list provided by Pyris.
Available models can be fetched through a newly created endpoint.
It is connected to ls1intum/Pyris#12

Steps for Testing

Go to the global/course/exercise settings and observe the new dropdown, which fetches its data from Pyris. (Only works if ls1intum/Pyris#12 is deployed as well)

Review Progress

Performance Review

  • I confirm that the server changes (in particular related to database calls) are implemented with a very good performance

Code Review

  • Code Review 1
  • Code Review 2

Manual Tests

  • Test 1
  • Test 2

Screenshots

grafik

@SolizerCodes SolizerCodes self-assigned this Jul 12, 2023
@github-actions github-actions bot added the server Pull requests that update Java code. (Added Automatically!) label Jul 12, 2023
@SolizerCodes SolizerCodes changed the title Added getting model from Pyris and endpoint Iris: Get offered models from Pyris Jul 12, 2023
@github-actions github-actions bot added the tests label Jul 12, 2023
@SolizerCodes SolizerCodes marked this pull request as ready for review July 16, 2023 22:03
@SolizerCodes SolizerCodes requested a review from a team as a code owner July 16, 2023 22:03
@SolizerCodes SolizerCodes requested a review from a team July 16, 2023 22:05
@github-actions github-actions bot added client Pull requests that update TypeScript code. (Added Automatically!) database Pull requests that update the database. (Added Automatically!). Require a CRITICAL deployment. labels Jul 17, 2023
@Hialus Hialus self-assigned this Jul 17, 2023
@SabrinaGlatz SabrinaGlatz added the deploy:artemis-test9 Testserver for Project Theia label Jul 17, 2023
@SabrinaGlatz SabrinaGlatz temporarily deployed to artemis-test9.artemis.cit.tum.de July 17, 2023 15:48 — with GitHub Actions Inactive
@github-actions github-actions bot added lock:artemis-test9 and removed deploy:artemis-test9 Testserver for Project Theia labels Jul 17, 2023
@SabrinaGlatz SabrinaGlatz added deploy:artemis-test9 Testserver for Project Theia and removed lock:artemis-test9 labels Jul 17, 2023
@SolizerCodes SolizerCodes added the deploy:artemis-test9 Testserver for Project Theia label Jul 18, 2023
@SolizerCodes SolizerCodes temporarily deployed to artemis-test9.artemis.cit.tum.de July 18, 2023 07:59 — with GitHub Actions Inactive
@github-actions github-actions bot added lock:artemis-test9 and removed deploy:artemis-test9 Testserver for Project Theia labels Jul 18, 2023
Copy link
Author

@SolizerCodes SolizerCodes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested the server stuff together with my server stuff and it works for me. The only problem I had was with the model that was selected globally. The model could not give me a response

@greekgeek1 greekgeek1 added the deploy:artemis-test9 Testserver for Project Theia label Jul 18, 2023
@github-actions github-actions bot added deployment-error Added by deployment workflows if an error occured and removed deploy:artemis-test9 Testserver for Project Theia labels Jul 18, 2023
@ls1intum ls1intum deleted a comment from github-actions bot Jul 18, 2023
@greekgeek1 greekgeek1 added deploy:artemis-test9 Testserver for Project Theia and removed deployment-error Added by deployment workflows if an error occured labels Jul 18, 2023
@greekgeek1 greekgeek1 temporarily deployed to artemis-test9.artemis.cit.tum.de July 18, 2023 09:51 — with GitHub Actions Inactive
@github-actions github-actions bot added lock:artemis-test9 and removed deploy:artemis-test9 Testserver for Project Theia labels Jul 18, 2023
Copy link

@SabrinaGlatz SabrinaGlatz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested on ts9 with all models, works as expected.

Copy link

@DemjenDavid DemjenDavid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested on ts9

@bassner bassner merged commit 04f1c2b into develop-iris Jul 18, 2023
38 of 45 checks passed
@bassner bassner deleted the feature/iris-dynamic-model-list branch July 18, 2023 11:45
@DemjenDavid DemjenDavid added the deploy:artemis-test9 Testserver for Project Theia label Jul 18, 2023
@github-actions github-actions bot added lock:artemis-test9 deployment-error Added by deployment workflows if an error occured and removed deploy:artemis-test9 Testserver for Project Theia labels Jul 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
client Pull requests that update TypeScript code. (Added Automatically!) component:Iris database Pull requests that update the database. (Added Automatically!). Require a CRITICAL deployment. deployment-error Added by deployment workflows if an error occured ready for review server Pull requests that update Java code. (Added Automatically!) tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants