-
Notifications
You must be signed in to change notification settings - Fork 291
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Lecture
: Allow instructors to remove solution slides when processing units
#6895
Conversation
src/main/java/de/tum/in/www1/artemis/service/LectureUnitProcessingService.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This PR only removes the sildes, it does not allow the instructor to reveal them again after the lecture ended. Can you add this as well to the PR?
.../lecture/lecture-unit/lecture-unit-management/attachment-units/attachment-units.component.ts
Show resolved
Hide resolved
Co-authored-by: Lucas Welscher <[email protected]>
@Strohgelaender no, thats what its intended. The reverting back process should be addressed in another PR as it requires bigger changes. |
src/main/java/de/tum/in/www1/artemis/service/LectureUnitProcessingService.java
Outdated
Show resolved
Hide resolved
…singService.java Co-authored-by: Lucas Welscher <[email protected]>
Co-authored-by: Simon Leiß <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I confirm that example solutions slides are removed (ts1)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested in testing session on ts1. Works as described
However, I'd love to see @JohannesStoehr`s suggestion implemented in a follow up :)
Why not offer the user a text box next to the option of removing the slides?
This way the user can choose the text themselves and it works for all lectures in all languages
src/main/java/de/tum/in/www1/artemis/service/LectureUnitProcessingService.java
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code looks fine :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code looks good to me.
Please keep the Follow up for user defined strings in mind
Checklist
General
Server
Client
Motivation and Context
Instructors are not able to remove "Example solution" slides when processing units automatically.
Description
A new checkbox is provided to choose if the instructors want to remove the solution slides. Then all example solution slides that contain "Example solution", "Example solution: model" or "Example solution (with comments)" will be removed.
Steps for Testing
Prerequisites:
example pdf:
ITP2223 L05 Object Orientation I_organized.pdf
Review Progress
Performance Review
Code Review
Manual Tests
Test Coverage
Client
Server
�
Screenshots
New checkbox introduced: