Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exam mode: Improve import icons in exercise group overview #6914

Merged
merged 3 commits into from
Jul 21, 2023

Conversation

JohannesStoehr
Copy link
Contributor

@JohannesStoehr JohannesStoehr commented Jul 16, 2023

Checklist

General

Client

  • Important: I implemented the changes with a very good performance, prevented too many (unnecessary) REST calls and made sure the UI is responsive, even with large data.
  • I followed the coding and design guidelines.
  • I added multiple screenshots/screencasts of my UI changes.

Motivation and Context

#6599 changed the icons for the import buttons from a plus to an icon symbolizing the import. This should also apply to the exercise groups in exams.

Description

Change the faPlus to faFileImport in the exercise groups for all import buttons.

Steps for Testing

Exam Mode Testing

Prerequisites:

  • 1 Instructor
  1. Log in to Artemis
  2. Create or find an exam
  3. Navigate to the exercise groups and create one if none are existent
  4. Look at the icons if they are suiting for each button

Review Progress

Performance Review

  • I confirm that the client changes (in particular related to REST calls and UI responsiveness) are implemented with a very good performance

Code Review

  • Code Review 1
  • Code Review 2

Manual Tests

  • Test 1
  • Test 2

Screenshots

Bildschirmfoto 2023-07-16 um 16 07 35

@github-actions

This comment was marked as outdated.

@github-actions github-actions bot added the deployment-error Added by deployment workflows if an error occured label Jul 16, 2023
@Strohgelaender Strohgelaender added deploy:artemis-test6 and removed deployment-error Added by deployment workflows if an error occured labels Jul 16, 2023
@Strohgelaender Strohgelaender temporarily deployed to artemis-test6.artemis.cit.tum.de July 16, 2023 15:08 — with GitHub Actions Inactive
@Strohgelaender
Copy link
Contributor

Looks good, you can now distinguish the add and import buttons even on smaller screens:

grafik

However, as you can see above the "Import File Upload Exercise" button uses the quiz exercise icon in the small mode, can you fix that directly?

SolizerCodes
SolizerCodes previously approved these changes Jul 16, 2023
Copy link

@SolizerCodes SolizerCodes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good on ts6

Copy link
Contributor

@eceeeren eceeeren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested on TS1, works well!

Copy link
Contributor

@MichaelOwenDyer MichaelOwenDyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good to me

Copy link

@DemjenDavid DemjenDavid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tested on ts3 i think it looks great, the icons make sense

Copy link

@fschoenberger fschoenberger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested on TS1, looks good!

Copy link
Contributor

@laadvo laadvo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code looks good to me 👍

@krusche krusche modified the milestones: 6.3.5, 6.3.6 Jul 21, 2023
@Mtze Mtze added the maintainer-approved The feature maintainer has approved the PR label Jul 21, 2023
@krusche krusche changed the title Exams: Improve import icons in exercise group overview Exam mode: Improve import icons in exercise group overview Jul 21, 2023
@krusche krusche merged commit 6280774 into develop Jul 21, 2023
36 of 39 checks passed
@krusche krusche deleted the enhancement/exams/use-import-icon-in-exercise-groups branch July 21, 2023 08:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
client Pull requests that update TypeScript code. (Added Automatically!) component:Exam Mode maintainer-approved The feature maintainer has approved the PR ready to merge small user interface
Projects
None yet
Development

Successfully merging this pull request may close these issues.

10 participants