-
Notifications
You must be signed in to change notification settings - Fork 291
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Assessment
: Fix the loss of submission text due to overlapping manual text blocks
#6916
Assessment
: Fix the loss of submission text due to overlapping manual text blocks
#6916
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you also add a test for this bug?
…https://github.com/ls1intum/Artemis into bugfix/text-exercises/overlapping-manual-text-blocks # Conflicts: # src/test/javascript/spec/component/text-submission-assessment/text-submission-assessment.component.spec.ts
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code with test LGTM 👍🏻
Works on ts4
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for adding the test. Code looks good to me 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
tested on ts4. Works as described.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code looks good to me 🎉 I also tested it again on TS4 to get a better feel of what the code is doing.
Checklist
General
Client
Motivation and Context
Closes #6903
Description
Removed the console error for the case when manual text blocks were overlapping. Instead, added some code to handle the case as follows: determine the block that has a feedback assigned to it and add a new text block, if needed, to ensure that the block of the new feedback does not hijack some of the existing text.
Steps for Testing
Prerequisites:
Review Progress
Performance Review
Code Review
Manual Tests
Test Coverage
Client