Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Development: Fix cypress dependency issue #7196

Merged
merged 3 commits into from
Sep 14, 2023
Merged

Conversation

TheZoker
Copy link
Contributor

Checklist

General

Motivation and Context

Currently the E2E test are failing since there is a dependency issue which has been resolved in this PR:
4teamwork/cypress-drag-drop#143

The issue is, that there has not been a release yet, which causes errors on our E2E run.

docker-artemis-cypress-1  | npm ERR! code ERESOLVE
docker-artemis-cypress-1  | npm ERR! ERESOLVE could not resolve
docker-artemis-cypress-1  | npm ERR!
docker-artemis-cypress-1  | npm ERR! While resolving: @4tw/[email protected]
docker-artemis-cypress-1  | npm ERR! Found: [email protected]
docker-artemis-cypress-1  | npm ERR! node_modules/cypress
docker-artemis-cypress-1  | npm ERR!   dev cypress@"13.2.0" from the root project
docker-artemis-cypress-1  | npm ERR!   peer cypress@">3.0.0" from [email protected]
docker-artemis-cypress-1  | npm ERR!   node_modules/cypress-file-upload
docker-artemis-cypress-1  | npm ERR!     dev cypress-file-upload@"5.0.8" from the root project
docker-artemis-cypress-1  | npm ERR!
docker-artemis-cypress-1  | npm ERR! Could not resolve dependency:
docker-artemis-cypress-1  | npm ERR! peer overridden cypress@"13.1.0" (was "^2.1.0 || ^3.1.0 || ^4.0.0 || ^5.0.0 || ^6.0.0 || ^7.0.0 || ^8.0.0 || ^9.0.0 || ^10.0.0 || ^11.0.0 || ^12.0.0") from @4tw/[email protected]
docker-artemis-cypress-1  | npm ERR! node_modules/@4tw/cypress-drag-drop
docker-artemis-cypress-1  | npm ERR!   dev @4tw/cypress-drag-drop@"2.2.4" from the root project
docker-artemis-cypress-1  | npm ERR!
docker-artemis-cypress-1  | npm ERR! Conflicting peer dependency: [email protected]
docker-artemis-cypress-1  | npm ERR! node_modules/cypress
docker-artemis-cypress-1  | npm ERR!   peer overridden cypress@"13.1.0" (was "^2.1.0 || ^3.1.0 || ^4.0.0 || ^5.0.0 || ^6.0.0 || ^7.0.0 || ^8.0.0 || ^9.0.0 || ^10.0.0 || ^11.0.0 || ^12.0.0") from @4tw/[email protected]
docker-artemis-cypress-1  | npm ERR!   node_modules/@4tw/cypress-drag-drop
docker-artemis-cypress-1  | npm ERR!     dev @4tw/cypress-drag-drop@"2.2.4" from the root project
docker-artemis-cypress-1  | npm ERR!
docker-artemis-cypress-1  | npm ERR! Fix the upstream dependency conflict, or retry
docker-artemis-cypress-1  | npm ERR! this command with --force or --legacy-peer-deps
docker-artemis-cypress-1  | npm ERR! to accept an incorrect (and potentially broken) dependency resolution.

Description

This PR fixes this by temporally ignoring the deps issue by applying --legacy-peer-deps to the npm ci task. This can be removed again, once the update for the drag and drop library is released.
This PR also renames the .bamboo folder to .ci, removed a cloud debugging setting for cypress and also renames the last occurrence of postgresql to postgres to stay consistent.

Review Progress

Code Review

  • Review 1
  • Review 2

@TheZoker TheZoker requested a review from a team as a code owner September 13, 2023 22:23
@github-actions github-actions bot added tests cypress Pull requests that update cypress tests. (Added Automatically!) docker labels Sep 13, 2023
@krusche krusche merged commit 1fa8b4e into develop Sep 14, 2023
22 of 27 checks passed
@krusche krusche deleted the test/cypress/fix-deps-issue branch September 14, 2023 08:12
@krusche krusche changed the title Development: Fix cypress deps issue Development: Fix cypress dependency issue Sep 14, 2023
@krusche krusche added this to the 6.5.0 milestone Sep 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cypress Pull requests that update cypress tests. (Added Automatically!) docker tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants