-
Notifications
You must be signed in to change notification settings - Fork 291
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Development
: Add build config entity for programming exercises
#8897
Development
: Add build config entity for programming exercises
#8897
Conversation
There hasn't been any activity on this pull request recently. Therefore, this pull request has been automatically marked as stale and will be closed if no further activity occurs within seven days. Thank you for your contributions. |
…cle/build-config-instructors
…onfig-instructors
fix error and remove unused method
adjust tests
fix columns
fix columns
adjust code
adjust code
adjust code
adjust code
adjust code
adjust code
adjust code
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 34
Outside diff range comments (1)
src/test/java/de/tum/in/www1/artemis/exercise/programming/ProgrammingExerciseFactory.java (1)
Line range hint
124-142
: Encapsulation Improvement SuggestionConsider encapsulating build configuration setup within
ProgrammingExerciseBuildConfig
to promote modularity and reduce direct manipulation of its properties.public class ProgrammingExerciseBuildConfig { public void initializeDefaults() { this.setTestwiseCoverageEnabled(false); this.setBuildScript("Some script"); this.setBuildPlanConfiguration("{\"api\":\"v0.0.1\",\"metadata\":{},\"actions\":[]}"); this.setBranch(DEFAULT_BRANCH); } }
...java/de/tum/in/www1/artemis/service/connectors/localci/LocalCIBuildConfigurationService.java
Show resolved
Hide resolved
src/main/java/de/tum/in/www1/artemis/repository/ProgrammingExerciseRepository.java
Show resolved
Hide resolved
src/main/java/de/tum/in/www1/artemis/repository/ProgrammingExerciseRepository.java
Show resolved
Hide resolved
src/main/java/de/tum/in/www1/artemis/repository/ProgrammingExerciseRepository.java
Show resolved
Hide resolved
src/main/java/de/tum/in/www1/artemis/repository/ProgrammingExerciseRepository.java
Show resolved
Hide resolved
src/main/java/de/tum/in/www1/artemis/repository/ProgrammingExerciseRepository.java
Show resolved
Hide resolved
src/main/java/de/tum/in/www1/artemis/repository/ProgrammingExerciseRepository.java
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 19
src/main/java/de/tum/in/www1/artemis/repository/BuildPlanRepository.java
Show resolved
Hide resolved
...ate-components/custom-build-plans/programming-exercise-custom-aeolus-build-plan.component.ts
Show resolved
Hide resolved
...ate-components/custom-build-plans/programming-exercise-custom-aeolus-build-plan.component.ts
Show resolved
Hide resolved
...ate-components/custom-build-plans/programming-exercise-custom-aeolus-build-plan.component.ts
Show resolved
Hide resolved
...ate/update-components/custom-build-plans/programming-exercise-custom-build-plan.component.ts
Show resolved
Hide resolved
src/main/webapp/app/exercises/programming/manage/programming-exercise-detail.component.ts
Show resolved
Hide resolved
src/main/java/de/tum/in/www1/artemis/service/programming/ProgrammingExerciseService.java
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code
…cle/build-config-instructors # Conflicts: # src/test/java/de/tum/in/www1/artemis/competency/CompetencyIntegrationTest.java
364d10a
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 29
Outside diff range comments (1)
src/main/java/de/tum/in/www1/artemis/service/connectors/gitlabci/GitLabCIService.java (1)
Line range hint
173-173
: Consider addressing TODO comments for variable management.The TODOs suggest improvements in managing variables at the group level and updating existing ones.
Would you like assistance in implementing these improvements or opening a GitHub issue to track them?
...java/de/tum/in/www1/artemis/service/connectors/localci/LocalCIBuildConfigurationService.java
Show resolved
Hide resolved
.../tum/in/www1/artemis/service/programming/ProgrammingExerciseFeedbackCreationServiceTest.java
Show resolved
Hide resolved
.../tum/in/www1/artemis/service/programming/ProgrammingExerciseFeedbackCreationServiceTest.java
Show resolved
Hide resolved
.../tum/in/www1/artemis/service/programming/ProgrammingExerciseFeedbackCreationServiceTest.java
Show resolved
Hide resolved
.../tum/in/www1/artemis/service/programming/ProgrammingExerciseFeedbackCreationServiceTest.java
Show resolved
Hide resolved
...n/java/de/tum/in/www1/artemis/service/programming/ProgrammingExerciseImportBasicService.java
Show resolved
Hide resolved
...a/de/tum/in/www1/artemis/exercise/programming/ProgrammingExerciseIntegrationTestService.java
Show resolved
Hide resolved
src/main/webapp/app/exercises/programming/manage/programming-exercise-detail.component.ts
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 26
src/main/java/de/tum/in/www1/artemis/service/connectors/localvc/LocalVCService.java
Show resolved
Hide resolved
.../java/de/tum/in/www1/artemis/exercise/programming/ProgrammingExerciseGradingServiceTest.java
Show resolved
Hide resolved
src/test/java/de/tum/in/www1/artemis/exam/ProgrammingExamIntegrationTest.java
Show resolved
Hide resolved
src/test/java/de/tum/in/www1/artemis/exam/ProgrammingExamIntegrationTest.java
Show resolved
Hide resolved
src/test/java/de/tum/in/www1/artemis/exam/ProgrammingExamIntegrationTest.java
Show resolved
Hide resolved
...spec/component/programming-exercise/programming-exercise-custom-build-plan.component.spec.ts
Show resolved
Hide resolved
...spec/component/programming-exercise/programming-exercise-custom-build-plan.component.spec.ts
Show resolved
Hide resolved
...spec/component/programming-exercise/programming-exercise-custom-build-plan.component.spec.ts
Show resolved
Hide resolved
src/main/java/de/tum/in/www1/artemis/repository/ProgrammingExerciseBuildConfigRepository.java
Show resolved
Hide resolved
...ava/de/tum/in/www1/artemis/web/rest/programming/ProgrammingExerciseExportImportResource.java
Show resolved
Hide resolved
Integrated code lifecycle
: Add BuildConfig entityDevelopment
: Add build config entity for programming exercises
🚨🚨🚨USE ONLY TS3
DO NOT DEPLOY TO TEST SERVERS🚨🚨🚨Checklist
General
Server
Client
Changes affecting Programming Exercises
Motivation and Context
To reduce database queries, we want to move some attributes from ProgrammingExercise to a new entity, ProgrammingExerciseBuildConfig. This is the first PR for this issue #8887
Steps for Testing
PLEASE DON'T DEPLOY TO TEST SERVERS UNTIL CODE REVIEWS ARE DONE
There are no particular testing steps, please test everything that comes to mind that's related to programming exercises. And please specify what you tested in a comment
General testing steps:
Testserver States
Note
These badges show the state of the test servers.
Green = Currently available, Red = Currently locked
Click on the badges to get to the test servers.
Review Progress
Performance Review
Code Review
Manual Tests
Summary by CodeRabbit
New Features
Bug Fixes
Tests