Exam Mode: Show exam announcements only for started exams
#9102
Conversation
github-actions
bot
added
the
client
coolchock
temporarily deployed
to
artemis-test4.artemis.cit.tum.de
GitHub Actions
Inactive
coolchock
temporarily deployed
to
artemis-test6.artemis.cit.tum.de
GitHub Actions
Inactive
…ments-after-exam-start
WalkthroughThe recent update simplifies the user interface of the exam participation cover component by removing the Changes
Sequence Diagram(s)sequenceDiagram
participant Student
participant ExamSystem
Student->>ExamSystem: Request Exam Start
ExamSystem-->>Student: Display Exam Title and Info
alt Exam Not Started
Student->>ExamSystem: Wait for Exam
ExamSystem-->>Student: No Live Events Button
end
alt Submission Failed
Student->>ExamSystem: Attempt Submission
ExamSystem-->>Student: Submission Error
ExamSystem-->>Student: No Live Events Button
end
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configuration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
edkaya
temporarily deployed
to
artemis-test4.artemis.cit.tum.de
GitHub Actions
Inactive
There was a problem hiding this comment.
Tested on ts4, did not get any notifications before I start the exam 👍 However, I think we still want to display notifications in end page, because it is part of an active exam period. Removing from that notification button also breaks the end page layout. (However, it is not so important, since we have a new end page design.)
| @@ -1,8 +1,5 @@ | |||
| @if (!startView && !studentFailedToSubmit) { | |||
| <div class="w-100 d-flex"> | |||
| <div class="col-md-3"> | |||
| <jhi-exam-live-events-button /> | |||
| </div> | |||
There was a problem hiding this comment.
Here should be added again (Line 3-5)
edkaya
temporarily deployed
to
artemis-test4.artemis.cit.tum.de
GitHub Actions
Inactive
There was a problem hiding this comment.
Besides, I also realized that if there are some changes before an exam starts, the notifications are not displayed in the welcome page but still displayed directly after we start with the exam, which I am not sure if it is the intended behaviour. Because the changes before the exam's start date should be irrelevant for the students in my opinion.
Server part will be adapted here #9136 |
|
There hasn't been any activity on this pull request recently. Therefore, this pull request has been automatically marked as stale and will be closed if no further activity occurs within seven days. Thank you for your contributions. |
…ments-after-exam-start # Conflicts: # src/main/webapp/app/exam/participate/exam-cover/exam-participation-cover.component.html
coolchock
dismissed stale reviews from undernagruzez, SimonEntholzer, Strohgelaender, and coderabbitai[bot]
via
d794609
Checklist
General
Motivation and Context
In issues #9010 and #9021, two problems regarding exam announcements were reported. Both issues involved exam announcements being displayed before the exam started and after the exam ended when the user opened the Exams tab on the course page. This pull request resolves both #9010 and #9021.
Description
The jhi-exam-live-events-button was present in the exam-participation-cover.component.html, which caused announcements to be displayed on the exam cover page. I removed the jhi-exam-live-events-button, so now announcements are only displayed if the user has started the exam and opened the exam-participation.component.html.
Exam Mode Testing
Prerequisites:
Testserver States
Note
These badges show the state of the test servers.
Green = Currently available, Red = Currently locked
Click on the badges to get to the test servers.
Review Progress
Performance Review
Code Review
Manual Tests
Exam Mode Test
Test Coverage
Screenshots
Summary by CodeRabbit