-
Notifications
You must be signed in to change notification settings - Fork 291
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
General
: Fix sorting on audit event log page
#9263
Conversation
WalkthroughThe changes made to the Changes
Assessment against linked issues
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
Documentation and Community
|
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
src/main/java/de/tum/in/www1/artemis/repository/PersistenceAuditEventRepository.java
Show resolved
Hide resolved
Development
: Fix audit log pageDevelopment
: Fix sorting on audit event log page
src/main/java/de/tum/in/www1/artemis/repository/PersistenceAuditEventRepository.java
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code looks good as discussed inline.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorting by date, user, and state works on TS3 & works across pages 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
tested on ts3, sorting works fine. Code also LGTM.
Development
: Fix sorting on audit event log pageGeneral
: Fix sorting on audit event log page
Checklist
General
Server
Motivation and Context
Fixes #9234
Description
This PR fixes the sorting on the audit events page. The issue occured, because fist the ids of the events is fetched, with the pageable parameter, which delivered them in the correct order. Unfortunately fetching the Entitygraph
findWithDataByIdIn(ids)
does not preserve this ordering.This fix sorts the actual events again, by the previously retrieved ids.
TL:DR
@Entitygraph
not preserving orderingSteps for Testing
Prerequisites:
Testserver States
Note
These badges show the state of the test servers.
Green = Currently available, Red = Currently locked
Click on the badges to get to the test servers.
Review Progress
Code Review
Manual Tests
Test Coverage
Screenshots
Before the fix (sorted by user name):
After fix, same sorting and date range: