Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Assessment: Fix exercise assessment dashboard submission numbering #9274

Merged

Conversation

SimonEntholzer
Copy link
Contributor

@SimonEntholzer SimonEntholzer commented Sep 3, 2024

Checklist

General

Client

  • Important: I implemented the changes with a very good performance, prevented too many (unnecessary) REST calls and made sure the UI is responsive, even with large data (e.g. using paging).
  • I strictly followed the client coding and design guidelines.
  • Following the theming guidelines, I specified colors only in the theming variable files and checked that the changes look consistent in both the light and the dark theme.
  • I added multiple screenshots/screencasts of my UI changes.

Motivation and Context

Fixes #9024

Description

Replaces the number in the exercise assessment dashboard with the submissions Id, to be able to use the sorting and find a submission again.

Steps for Testing

Prerequisites:

  • 1 Instructor
  • 2 Students
  • 1 Programming Exercise with manual assessment enabled
  1. With the student accounts submit to the exercise.
  2. As the instructor set the due date of the exercise to now.
  3. With a tutor or instructor account assess the two submissions.
  4. In the exercise assessment dashboard, verify you can distinguish the submissions by Id and find individual submissions of which you remembered the id.

Testserver States

Note

These badges show the state of the test servers.
Green = Currently available, Red = Currently locked
Click on the badges to get to the test servers.







Review Progress

Code Review

  • Code Review 1
  • Code Review 2

Manual Tests

  • Test 1
  • Test 2

Exam Mode Test

  • Test 1
  • Test 2

Test Coverage

Screenshots

Before the change:
image

After the change:
image

@SimonEntholzer SimonEntholzer added client Pull requests that update TypeScript code. (Added Automatically!) bugfix labels Sep 3, 2024
@SimonEntholzer SimonEntholzer self-assigned this Sep 3, 2024
@SimonEntholzer SimonEntholzer requested a review from a team as a code owner September 3, 2024 11:34
Copy link

coderabbitai bot commented Sep 3, 2024

Walkthrough

The changes made to the exercise-assessment-dashboard.component.html file involve updates to the submission table's header and row content. The submission ID column header has been enhanced for clarity and sorting functionality, while the displayed submission identifier has been changed from a sequential index to the actual submission ID, improving the identification of submissions.

Changes

Files Change Summary
src/main/webapp/app/exercises/shared/dashboards/tutor/exercise-assessment-dashboard.component.html Updated submission ID header for sorting and changed displayed submission index to actual ID.

Assessment against linked issues

Objective Addressed Explanation
Assessment Dashboard has no stable number ( #9024 )

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai or @coderabbitai title anywhere in the PR title to generate the title automatically.

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link
Contributor

@Strohgelaender Strohgelaender left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

makes sense, code looks good!

Copy link
Contributor

@coolchock coolchock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tested on ts2, works as expected! code also LGTM

Copy link
Contributor

@pzdr7 pzdr7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works as described on TS2 👍

@b-fein b-fein added this to the 7.5.2 milestone Sep 4, 2024
@krusche krusche changed the title Development: Fix exercise assessment dashboard submission numbering Assessment: Fix exercise assessment dashboard submission numbering Sep 6, 2024
@krusche krusche merged commit 299b623 into develop Sep 6, 2024
17 of 22 checks passed
@krusche krusche deleted the chore/bugfix/stable-id-for-exercise-assessment-dashboard branch September 6, 2024 21:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bugfix client Pull requests that update TypeScript code. (Added Automatically!) ready to merge small
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Assessment: Assessment Dashboard has no stable number
6 participants