-
Notifications
You must be signed in to change notification settings - Fork 291
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Development
: Remove no longer required secret push token for Jenkins setups
#9317
Development
: Remove no longer required secret push token for Jenkins setups
#9317
Conversation
Development
: Remove no longer required secret push token for GitLab setupsDevelopment
: Remove no longer required secret push token for Jenkins setups
I'll test the PR asap |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes make sense.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code 👍
…nces-to-outdated-secret-push-token
…exercises/remove-references-to-outdated-secret-push-token
@@ -691,6 +691,18 @@ Start Jenkins | |||
user: your.chosen.username | |||
password: your.chosen.password | |||
|
|||
11. In a local setup, you have to disable CSRF otherwise some API endpoints will return HTTP Status 403 Forbidden. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Note: this is not new, but got lost when removing the secret push token section in #9266.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
code changes make sense 👍
…nces-to-outdated-secret-push-token
I confirmed on a test system that the web-hook from GitLab to Jenkins does indeed no longer exist and did not before this PR either. Therefore, the Jenkins secret token is never used to trigger build plans in existing systems already. This ensures currently running GitLab+Jenkins setups will not break. Since I don’t think anyone else testing PRs is using the deprecated GitLab+Jenkins setup any more (and it is definitely not worth setting it up just for this), I will count this as the manual test and mark this PR as ready to merge. |
Checklist
General
Server
Changes affecting Programming Exercises
Motivation and Context
Since #6682 the builds are no longer triggered in Jenkins from GitLab directly. Instead, Artemis triggers the build by using the regular API authentication of Jenkins.
The secret token was only used to allow GitLab to trigger builds directly in Jenkins. Since this feature is no longer used it can be removed.
It also does not make sense to keep it since it is not required for LocalVC+Jenkins setups.
Description
Removed references to the no longer needed
secret-push-token
config option.As should be clear from the server code changes, the secret token is only used when creating the initial build plan. When triggering builds in the Jenkins, Artemis does not use it.
Steps for Testing
Prerequisites:
Testserver States
Note
These badges show the state of the test servers.
Green = Currently available, Red = Currently locked
Click on the badges to get to the test servers.
Review Progress
Code Review
Manual Tests
Test Coverage
unchanged
Screenshots
n/a
@coderabbitai ignore