Development: Refactor atlas tests

[MaximilianAnzinger]

Checklist

General

• I chose a title conforming to the naming conventions for pull requests.

Server

• Important: I implemented the changes with a very good performance and prevented too many (unnecessary) and too complex database calls.
• I strictly followed the server coding and design guidelines.
• I documented the Java code using JavaDoc style.

Motivation and Context

Description

Introduces AbstractAtlasIntegrationTest and moves all @Autowire into the abstract test class.

Review Progress

Code Review

• Code Review 1
• Code Review 2

Test Coverage

unchanged

Summary by CodeRabbit

Summary by CodeRabbit

• New Features

  • Introduced a new abstract class for integration tests, providing a shared setup for various test classes.

• Bug Fixes

  • Removed unnecessary dependencies from the LearningPathIntegrationTest class, simplifying its setup and execution.

• Refactor

  • Refactored LearningPathIntegrationTest to extend the new abstract class, enhancing consistency and reducing complexity.

[JohannesStoehr]

Approve refactored code

[cremertim]

Refactored code lgtm

[coderabbitai]

Actionable comments posted: 2

📜 Review details

Configuration used: .coderabbit.yaml
Review profile: ASSERTIVE

📥 Commits

Files that changed from the base of the PR and between ccebd40 and 62a76c6.

📒 Files selected for processing (1)

• src/test/java/de/tum/cit/aet/artemis/atlas/learningpath/LearningPathIntegrationTest.java (2 hunks)

🧰 Additional context used

📓 Path-based instructions (1)

src/test/java/de/tum/cit/aet/artemis/atlas/learningpath/LearningPathIntegrationTest.java (1)

Pattern src/test/java/**/*.java: test_naming: descriptive; test_size: small_specific; fixed_data: true; junit5_features: true; assert_use: assertThat; assert_specificity: true; archunit_use: enforce_package_rules; db_query_count_tests: track_performance; util_service_factory_pattern: true; avoid_db_access: true; mock_strategy: static_mocks; context_restart_minimize: true

📓 Learnings (1)

src/test/java/de/tum/cit/aet/artemis/atlas/learningpath/LearningPathIntegrationTest.java (1)

Learnt from: julian-christl
PR: ls1intum/Artemis#8052
File: src/test/java/de/tum/in/www1/artemis/lecture/CompetencyIntegrationTest.java:310-310
Timestamp: 2024-02-23T00:03:06.365Z
Learning: Modifications to parameters in `competencyProgressUtilService.createCompetencyProgress` for debugging purposes are considered irrelevant to the test outcomes but helpful for clarity during debugging.

🔇 Additional comments (1)

src/test/java/de/tum/cit/aet/artemis/atlas/learningpath/LearningPathIntegrationTest.java (1)

53-53: Verify the impact of extending a different base class.

Extending AbstractAtlasIntegrationTest instead of AbstractSpringIntegrationIndependentTest may introduce changes in the test setup, lifecycle, and available utilities. Carefully review the differences between these base classes and ensure that the existing test methods are still valid and compatible with the new base class.

[coderabbitai]

Actionable comments posted: 1

📜 Review details

Configuration used: .coderabbit.yaml
Review profile: ASSERTIVE

📥 Commits

Files that changed from the base of the PR and between 62a76c6 and 28b9ce4.

📒 Files selected for processing (1)

• src/test/java/de/tum/cit/aet/artemis/atlas/AbstractAtlasIntegrationTest.java (1 hunks)

🧰 Additional context used

📓 Path-based instructions (1)

src/test/java/de/tum/cit/aet/artemis/atlas/AbstractAtlasIntegrationTest.java (1)

Pattern src/test/java/**/*.java: test_naming: descriptive; test_size: small_specific; fixed_data: true; junit5_features: true; assert_use: assertThat; assert_specificity: true; archunit_use: enforce_package_rules; db_query_count_tests: track_performance; util_service_factory_pattern: true; avoid_db_access: true; mock_strategy: static_mocks; context_restart_minimize: true

🔇 Additional comments (1)

src/test/java/de/tum/cit/aet/artemis/atlas/AbstractAtlasIntegrationTest.java (1)

1-159: Overall, the code changes look good

The introduction of AbstractAtlasIntegrationTest consolidates the @Autowired dependencies into a common abstract class for the Atlas integration tests. This promotes code reuse and simplifies the test classes that will extend this abstract class.

[coderabbitai]

🧹 Nitpick (assertive)

Add JavaDoc comment to the class definition

Consider adding a JavaDoc comment to the AbstractAtlasIntegrationTest class to describe its purpose and usage. This will enhance code readability and help other developers understand the intent of this abstract test class.

[JohannesWt]

Code 👍

[JohannesStoehr]

Approve refactoring