Development: Fix flaky server tests
#9428
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
tests
programming
This reverts commit c306b8d.
MaximilianAnzinger
changed the title
Development: fix flaky server testsDevelopment: Fix flaky server tests
ole-ve
reviewed
Oct 11, 2024
| // TestInstance.Lifecycle.PER_CLASS allows all test methods in this class to share the same instance of the test class. | ||
| // This reduces the overhead of repeatedly creating and tearing down a new Spring application context for each test method. | ||
| // This is especially useful when the test setup is expensive or when we want to share resources, such as database connections or mock objects, across multiple tests. | ||
| // In this case, we want to share the same GitService and UsernamePasswordCredentialsProvider. | ||
| @TestInstance(TestInstance.Lifecycle.PER_CLASS) |
There was a problem hiding this comment.
I had the same idea but that's implicit default behavior, see.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
General
Motivation and Context
Fix flaky
LocalVCLocalCIIntegrationTesttestsSteps for Testing
LocalVCLocalCIIntegrationTestshould passTestserver States
Note
These badges show the state of the test servers.
Green = Currently available, Red = Currently locked
Click on the badges to get to the test servers.
Review Progress
Code Review
Test Coverage
Screenshots