Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Iris
: Track token usage of iris requests #9455base: develop
Are you sure you want to change the base?
Iris
: Track token usage of iris requests #9455Changes from 4 commits
a5dfdbb
d0bdae3
2a08cb2
f85cf46
65fb259
188ff22
be85a3b
e974d59
6337162
84a60dc
5b0ab48
62dad8b
897d643
1d10860
8b27861
86294c1
56b20e7
8a29c82
abbd28f
8d34428
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🧹 Nitpick (assertive)
Consider adding JavaDoc comments for the class
Adding a class-level JavaDoc comment can improve code readability and help other developers understand the purpose and usage of this entity.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🛠️ Refactor suggestion
Consider Using an Enum for
model
FieldSimilar to
serviceType
, themodel
field could benefit from being anenum
to ensure only valid model names are used.Apply these changes:
Define an
enum
forLLMModel
:Update the
LLMTokenUsage
class:Update the getter and setter methods:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🛠️ Refactor suggestion
Consider Mapping
userId
as a@ManyToOne
RelationshipMapping the
userId
field as a@ManyToOne
relationship to theUser
entity can enhance data integrity and simplify user-related queries.Apply these changes:
Update the field declaration:
Update the getter and setter methods:
Ensure that you import the necessary classes:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add null check before setting
course
to prevent potentialNullPointerException
The
course
parameter may benull
in some cases, as seen in the overloaded methods wherecourse
could be omitted. To ensure robustness, add a null check before setting the course inllmTokenUsage
.Apply this diff to add the null check:
📝 Committable suggestion