General: Border-radius is now consistent on sidebar

[FleckiBunti]

Checklist

General

• I tested all changes and their related features with all corresponding user types on a test server.
• This is a small issue that I tested locally and was confirmed by another developer on a test server.
• Language: I followed the guidelines for inclusive, diversity-sensitive, and appreciative language.
• I chose a title conforming to the naming conventions for pull requests.

Client

• I strictly followed the client coding and design guidelines.
• Following the theming guidelines, I specified colors only in the theming variable files and checked that the changes look consistent in both the light and the dark theme.
• I added multiple screenshots/screencasts of my UI changes.

Motivation and Context

The border-radius of the Sidebar in a course was inconsistent.
(Closes #9107)

Description

Removed rounded-end from the mat-sidenav.
Note that this leaves the exercise-header unchanged, which is rounded differently.

Steps for Testing

Prerequisites:

• 1 Course

1. Log in to Artemis
2. Navigate to the Course
3. View the Sidebar

Testserver States

Note

These badges show the state of the test servers.
Green = Currently available, Red = Currently locked
Click on the badges to get to the test servers.

Review Progress

Performance Review

• I (as a reviewer) confirm that the client changes (in particular related to REST calls and UI responsiveness) are implemented with a very good performance even for very large courses with more than 2000 students.
• I (as a reviewer) confirm that the server changes (in particular related to database calls) are implemented with a very good performance even for very large courses with more than 2000 students.

Code Review

• Code Review 1
• Code Review 2

Manual Tests

• Test 1
• Test 2

Exam Mode Test

• Test 1
• Test 2

Performance Tests

• Test 1
• Test 2

Screenshots

Old:

New:

Summary by CodeRabbit

• Style
  • Updated the sidebar styling by removing the rounded-end class, enhancing the visual presentation of the course overview component.

[coderabbitai]

Walkthrough

The changes in this pull request involve a modification to the HTML template of the course-overview.component.html file. Specifically, the rounded-end class has been removed from the mat-sidenav element, which impacts the styling of the sidebar component. The remaining classes for the mat-sidenav are now module-bg and rounded-3, maintaining the existing structure and functionality of the component.

Changes

File Path	Change Summary
src/main/webapp/app/overview/course-overview.component.html	Removed rounded-end class from mat-sidenav; retains module-bg and rounded-3 classes.

Assessment against linked issues

Objective	Addressed	Explanation
Inconsistent border radius of sidebar (#9107)	✅

Possibly related PRs

• General: Elevate toggle sidebar button #9411: This PR modifies the course-overview.component.html file, focusing on enhancing the sidebar toggle button's visibility and functionality.
• General: Animate content sidebar on toggle #9412: This PR introduces animations for the sidebar toggle, directly relating to the visual aspects of the sidebar.

Suggested labels

bugfix, client, ready to merge

Suggested reviewers

• rabeatwork
• JohannesStoehr
• edkaya
• krusche

---

📜 Recent review details

Configuration used: .coderabbit.yaml
Review profile: ASSERTIVE

📥 Commits

Files that changed from the base of the PR and between a5167be and 3eb3432.

📒 Files selected for processing (1)

• src/main/webapp/app/overview/course-overview.component.html (1 hunks)

🧰 Additional context used

📓 Path-based instructions (1)

src/main/webapp/app/overview/course-overview.component.html (1)

Pattern src/main/webapp/**/*.html: @if and @for are new and valid Angular syntax replacing *ngIf and *ngFor. They should always be used over the old style.

🔇 Additional comments (1)

src/main/webapp/app/overview/course-overview.component.html (1)

16-16: LGTM: Change aligns with PR objectives

The removal of the rounded-end class from the mat-sidenav element successfully addresses the inconsistency in the sidebar's border-radius. This change:

1. Aligns with the PR objective of ensuring a uniform appearance of the sidebar.
2. Directly addresses the issue mentioned in Inconsistent border radius of sidebar #9107.
3. Maintains the overall rounding with the rounded-3 class, likely providing a consistent look across all corners.

The modification is minimal and doesn't affect the functionality of the component, focusing solely on the visual consistency as intended.

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai or @coderabbitai title anywhere in the PR title to generate the title automatically.

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[raffifasaro]

Code LGTM

[Strohgelaender]

Thanks!