`Development`: Add truncate function #15

Hialus · 2023-07-19T11:13:47Z

Add a simple truncate function for guidance to use.

MichaelOwenDyer

Looks good :)

app/services/guidance_functions.py

dakennguyen

pls add test for it. Can max_length be negative?

app/services/guidance_wrapper.py

Add truncate function

b2abb60

Hialus requested review from dakennguyen and MichaelOwenDyer July 19, 2023 11:13

Hialus self-assigned this Jul 19, 2023

MichaelOwenDyer previously approved these changes Jul 19, 2023

View reviewed changes

dakennguyen reviewed Jul 19, 2023

View reviewed changes

app/services/guidance_functions.py Outdated Show resolved Hide resolved

dakennguyen suggested changes Jul 19, 2023

View reviewed changes

dakennguyen reviewed Jul 19, 2023

View reviewed changes

app/services/guidance_wrapper.py Show resolved Hide resolved

Add tests

d0a5859

dakennguyen dismissed MichaelOwenDyer’s stale review via d0a5859 July 19, 2023 11:38

dakennguyen self-assigned this Jul 19, 2023

Add test

36029eb

dakennguyen previously approved these changes Jul 19, 2023

View reviewed changes

Hialus added the deploy:pyris-test label Jul 19, 2023

github-actions bot added lock:pyris-test and removed deploy:pyris-test labels Jul 19, 2023

Hialus temporarily deployed to Iris Test July 19, 2023 12:15 — with GitHub Actions Inactive

Merge branch 'main' into feature/truncate-function

c7a6ff1

bassner dismissed dakennguyen’s stale review via c7a6ff1 July 22, 2023 14:07

bassner removed the lock:pyris-test label Jul 22, 2023

bassner merged commit 94d78e5 into main Jul 22, 2023
2 checks passed

Hialus deleted the feature/truncate-function branch July 22, 2023 14:35

Provide feedback