Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Development: Add better error reporting #9

Merged
merged 4 commits into from
Jul 11, 2023

Conversation

Hialus
Copy link
Member

@Hialus Hialus commented Jul 4, 2023

Description

This PR adds more exception types to Pyris, which allows Pyris to better describe what went wrong in the response.
ls1intum/Artemis#6819 uses this to determine what the error was and reports it to the user.

@Hialus Hialus self-assigned this Jul 4, 2023
@Hialus Hialus marked this pull request as ready for review July 4, 2023 18:33
@Hialus Hialus requested a review from dakennguyen July 11, 2023 12:35
@Hialus Hialus requested a review from dakennguyen July 11, 2023 15:59
Copy link
Contributor

@dakennguyen dakennguyen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

one more small thing, otherwise it LGTM

app/routes/messages.py Outdated Show resolved Hide resolved
@Hialus Hialus requested a review from dakennguyen July 11, 2023 19:22
@Hialus Hialus merged commit bf16ac8 into main Jul 11, 2023
2 checks passed
@Hialus Hialus deleted the feature/better-error-reporting branch July 11, 2023 21:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants