Chore: Unify PushNoficationSettingsScreen and NotificationSettingsUi & unsaved changes dialog
#287
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…n a new composable and added unsaved changes dialog
FelberMartin
requested changes
Jan 10, 2025
There was a problem hiding this comment.
Thank you for taking care of this, it really confused me that we previously had two very similar composables for this :D
Just some minor code comments and two general remarks:
- I noticted that the Unsaved changes dialog only appear when navigating back via the arrow in the top left, but not with the Android back button.
- When making some changes, then turning on airplane mode, and navigating back, the dialog shows. When I press "Yes/Save" I get taken back to the settings screen, but the changes are actually not synced to the server. Maybe we should stay on the notificationSettingsScreen until the syncing is successful, or display an error message otherwise
...de/tum/informatics/www1/artemis/native_app/feature/push/ui/PushNotificationSettingsScreen.kt
Outdated
Show resolved
Hide resolved
...de/tum/informatics/www1/artemis/native_app/feature/push/ui/PushNotificationSettingsScreen.kt
Outdated
Show resolved
Hide resolved
...de/tum/informatics/www1/artemis/native_app/feature/push/ui/PushNotificationSettingsScreen.kt
Show resolved
Hide resolved
feature/push/src/main/res/values/push_notification_settings_strings.xml
Outdated
Show resolved
Hide resolved
FelberMartin
added
ready to merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem Description
As mentioned in #273 there a two composable functions right now, which both use
PushNotificationSettingsUito display notification settings.Changes
This PR combines both functions into a new function called
PushNotificationSettingsScreen.Moreover, a new dialog has been added to warn users if there are unsaved changes after adjusting their notification settings.
Steps for testing