Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Redesign of Student Application Page and Application Filtering #695

Merged
merged 8 commits into from
Oct 2, 2024

Conversation

niclasheun
Copy link
Collaborator

Description

This PR updates the UI of the student application page. It follows Bene's style guidelines and with a redesign of the filtering options, it aims to offer a smoother user experience.

Type of change

  • New feature
  • Introduced a new filtering menu, which also allows to filter by setting a score range (min & max score) as well as to directly filter for the applications which have not been assigned a score.
  • Removed filtering in the table (the old version had two different places for filtering. The table and the filter button. Now the filtering option inside the table header is removed and filtering only happens in the filter menu)
  • Redesigned and enhanced page header
  • 'filter chips' which display the currently selected filters

Known Issues

  • 'Add Student' is currently an non-functional button. This functionality is already implemented, but in its own branch (to keep this PR small)

How Has This Been Tested?

This has been manually tested with my local development setup.

  • Dark Mode / Light Mode
  • Resetting of filters
  • Applying multiple / all filters

Changes

image

@niclasheun niclasheun self-assigned this Sep 26, 2024
@niclasheun niclasheun linked an issue Sep 26, 2024 that may be closed by this pull request
@Mtze
Copy link
Member

Mtze commented Sep 30, 2024

Very nice change! I tested in on the dev instance. Since the intro course segment has a similar list, i think it would be good to also change the filters there. Is this something you wanna do in this PR or would you like to open a followup PR?

@niclasheun
Copy link
Collaborator Author

Thank you! If it is ok for you, I can just do it in the same PR.

@Mtze
Copy link
Member

Mtze commented Sep 30, 2024

Fine by me :)

@niclasheun
Copy link
Collaborator Author

After looking into the Intro Course Page, I would rather prefer to have it on a separate branch and merge this change individually.

@Mtze Mtze merged commit 5a072fd into main Oct 2, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Filter for score
2 participants