Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: add winget releaser workflow #887

Merged
merged 1 commit into from
Aug 20, 2024
Merged

Conversation

sitiom
Copy link
Contributor

@sitiom sitiom commented Aug 29, 2023

This action automatically generates manifests for Winget Community Repository (microsoft/winget-pkgs) and submits them.

lsd has been added to Winget in microsoft/winget-pkgs#118210, and this workflow will be used to update it.

Before merging this:

  1. Add a classic PAT with public_repo scope as a repository secret named WINGET_TOKEN. You can go to this URL to create it: https://github.com/settings/tokens/new?scopes=public_repo

example

  1. Fork https://github.com/microsoft/winget-pkgs under @lsd-rs. The action will use that fork for making a branch and creating a PR with the upstream winget-pkgs repository on every release.
  2. Install Pull on the winget-pkgs fork to ensure that it is constantly updated.

If you want to see an example of a PR created using this action, see microsoft/winget-pkgs/pulls (Pull request has been created with WinGet Releaser).


TODO

  • Use cargo fmt
  • Add necessary tests
  • Add changelog entry
  • Update default config/theme in README (if applicable)
  • Update man page at lsd/doc/lsd.md (if applicable)

Copy link

muniu-bot bot commented Jul 30, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: sitiom
Once this PR has been reviewed and has the lgtm label, please assign zwpaper for approval by writing /assign @zwpaper in a comment. For more information see:The Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sitiom
Copy link
Contributor Author

sitiom commented Aug 20, 2024

Bump @zwpaper

@sitiom sitiom mentioned this pull request Aug 20, 2024
@zwpaper
Copy link
Member

zwpaper commented Aug 20, 2024

Sorry for the late reply, I am not a windows user. the PR seems detailed enough, thanks for the help and let's merge it to see whether magic will happen

@zwpaper zwpaper merged commit 6f9262f into lsd-rs:master Aug 20, 2024
17 of 19 checks passed
@sitiom
Copy link
Contributor Author

sitiom commented Aug 21, 2024

@zwpaper Windows build failed https://github.com/lsd-rs/lsd/actions/runs/10475485501? (Winget releaser depends on it)

@sitiom sitiom deleted the winget-releaser branch August 21, 2024 03:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support for winget
2 participants