Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

updates for Angular8 #13

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

404Assassin
Copy link

Rather then try and go through the Angular update process, across so many major versions, I started a new Angular8 project created with the cli and copied your code into it Class by Class. Applied fixes to recent TypeScript and Angular8 changes like directive attributes. Also changed some minor stuff to reflect recent Angular best practices, like direct imports instead of barrel indexes etc. Fixed some items that TSLint and IntelliJ were complaining about (like selectors). It's essentially your code in a new ng8 project.

@lsharir
Copy link
Owner

lsharir commented Sep 12, 2019

Thanks! I'll go over it during the weekend. Is there an easy way to remove the tests files \ packages? I originally built it without tests as to not confuse new developers with unnecessary code

@dhruv217
Copy link

I would suggest leaving the test in there, for reminding the uninitiated of having less on an anxiety attack before deploying to production.

@Mech0z
Copy link

Mech0z commented Jan 20, 2020

Any updates to this?

@404Assassin
Copy link
Author

You're welcome to check my version out here: https://github.com/404Assassin/angular-d3-graph-example/tree/ng8
It still includes the test files and I haven't had the time to either wirer them up correctly or remove them. I would like to wirer them up at some point so that they are returning something meaningful, just haven't had the time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants