DM-41292: Migrate from flake8 to ruff
#6
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eacharles
approved these changes
Oct 23, 2023
|
|
||
| def __init__(self, url: str) -> None: | ||
| def __init__(self: "CMClient", url: str) -> None: |
There was a problem hiding this comment.
Wow, python's butchery of typing reaches epic levels
| @@ -21,7 +21,7 @@ def get_productions(self) -> list[models.Production]: | |||
| skip += len(results) | |||
| return productions | |||
|
|
|||
| def get_campaigns(self, production: int | None = None) -> list[models.Campaign]: | |||
| def get_campaigns(self: "CMClient", production: int | None = None) -> list[models.Campaign]: | |||
There was a problem hiding this comment.
Not sure what Type I am, good thing this string here tells me.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
flake8is old and busted.ruffis new hotness.(Way faster, can check many more things, supports auto-fixes, actively and non-obstructively maintained, better
pyproject.tomlintegration, and is the new lint tooling trend for DM.)Would like to get this in ahead of
eac-devbranch re-work; that branch currently has some lint and we might as well address that in relation to the modern linter.