Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tickets/dm 46171: allow for running against sqllite db #98

Merged
merged 6 commits into from
Sep 18, 2024

Conversation

eacharles
Copy link
Collaborator

No description provided.

@eacharles eacharles changed the title Tickets/dm 46171 Tickets/dm 46171: allow for running against sqllite db Sep 6, 2024
Makefile Outdated

.PHONY: run-mysql
run-mysql: export CM_DATABASE_URL=sqlite+aiosqlite://///test_cm.db
#run-mysql: export CM_DATABASE_SCHEMA=${USER}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove dead wood comments?

Copy link
Member

@fritzm fritzm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks! Please consider removing dead wood comments in Makefile

@eacharles eacharles merged commit 708474e into main Sep 18, 2024
9 checks passed
@eacharles eacharles deleted the tickets/DM-46171 branch September 18, 2024 17:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants