Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DM-45484: Initial commit of pipetask to run RAIL p(z) estimation stages. #1
DM-45484: Initial commit of pipetask to run RAIL p(z) estimation stages. #1
Changes from 26 commits
b78181c
b633d81
a7adfe0
6a80313
3f85ca9
e620dd0
f235622
e9aed01
75460b0
90b2ea7
460ddde
f882c60
3cc9676
08fefdf
cb09cc1
b550ead
dca93cd
c711041
57eec34
cde1ab4
47a8ade
40b9f25
2d0edd9
9dda8b1
34cad68
ff6e598
e10dec3
5b31127
50519d2
781d45a
b0355af
0e50a78
607e648
80c94b7
f2222f3
bad9322
d185550
1ca7b57
c8ede51
6c8b201
e59bb9f
65bab23
b3fe18e
fb5c8f2
e2fd9e6
5d6b86d
c6cf708
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
Large diffs are not rendered by default.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's fairly common practice to make convenient subclasses of tasks that override
setDefaults
with everything you've put into the Python block. You may end up needing to do that if you want to set obs package overrides anyway.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So, I see a number of cases of overriding setDefaults in config classes. Are you saying that I should make additional Config / Pipetask class pairs for each algorithm? So that each algorithm has four classes: a config / task pair to do the algorithm and config Pipetask pair to select the particular Task. is that correct?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
FYI you can put the string and other plain old data overrides outside of the python block since the python block always runs first. It's just the import and retarget call that need to go here.