DM-42063: No task logs in Prompt Processing output #106
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Assigning the temporary Butler to a local variable makes it usable at other pipeline execution steps.
This factory can be shared among multiple components. The explicit namespace is to disambiguate ctrl.mpexec.TaskFactory from pipe.base.TaskFactory.
This config never uses multiprocessing, avoiding problems associated with spawning.
hsinfang
approved these changes
Dec 7, 2023
| ) | ||
| graph_executor = MPGraphExecutor( | ||
| # TODO: re-enable parallel execution once we can log as desired with CliLog or a successor | ||
| # (see issues linked from DM-42063) |
There was a problem hiding this comment.
Looks like a good workaround for the time being. Maybe we should create a new ticket for the future work discussed at Slack on more properly engineering this even if that may not happen soon?
There was a problem hiding this comment.
I think it will need to be done piece by piece, and would prefer to avoid a Big Design Discussion that tries to solve everything at once. I hope to discuss the details with Middleware after catching up on backlog.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR turns off multiprocessing in pipeline execution, preventing a bug where task logs were not going through our logger. This is a mid-term workaround; we expect to restore compatibility with multiprocessing in the future.