DM-45024: Reconcile PP workflows with "quick-stack" builds #184
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The condition was supposed to special-case d_latest and w_latest, but was never tripped.
This is a port of the patches already made to build-service.yml, and gives us more flexibility in building nonstandard containers.
The Actions UI already prints the default.
build-base.yml still defaults to lsstsqre/centos, and has some special treatment for that case, but allows any container to be used self-consistently.
kfindeisen
force-pushed
the
tickets/DM-45024
branch
from
733bbd0
to
9bdf750
Compare
erinleighh
approved these changes
Jul 25, 2024
Inputs are only defined when running the workflow manually; all inputs are null when running from the PR.
The "ENV <variable> <value>" form is deprecated and raises a warning in docker build.
kfindeisen
force-pushed
the
tickets/DM-45024
branch
from
9bdf750
to
48c6ec6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes some old issues with the
build-base.ymlworkflow and adds support for pipeline containers other thanlsstsqre/centos.