DM-46312: Migrate unit tests to ComCamSim data #199
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kfindeisen
force-pushed
the
tickets/DM-46312
branch
from
4687c0b
to
2e770c0
Compare
kfindeisen
changed the title
hsinfang
approved these changes
Sep 16, 2024
|
Oops, so that's where |
|
Another comment: with this update, we no longer need |
DECam is increasingly unrepresentative of expected LSST data, and the original dataset (adapted from ap_verify) had a nonstandard repository layout that had to be special-cased. ComCamSim should provide a more realistic data set going forward. The unit test repository remains at dimensions-config 6.
This commit also removes all dimension records relating to the DECam instrument or the decam_rings_v1 skymap from the registry.
Tests previously used a mock pipeline because no preprocessing tasks had been implemented, and empty pipelines are invalid.
kfindeisen
force-pushed
the
tickets/DM-46312
branch
from
2e770c0
to
ac53e31
Compare
|
@hsinfang would you like to take a look at |
|
Looks great to me, and it will also serve as a good reference if later we want to build a new repo with another dataset. Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR migrates the unit test repo from DECam to ComCamSim, and cleans up some related technical debt.