DM-47333: Logger.exception() missing 1 required positional argument #213
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timj
approved these changes
Nov 1, 2024
timj
reviewed
Nov 1, 2024
hsinfang
force-pushed
the
tickets/DM-47333
branch
from
8616825
to
0de0ced
Compare
Otherwise it complains about the required positional argument
hsinfang
force-pushed
the
tickets/DM-47333
branch
from
96d6f35
to
3bd2fea
Compare
kfindeisen
reviewed
Nov 4, 2024
| _log.exception() | ||
| return f"Bad Request: {msg}", 400 | ||
| except ValueError as e: | ||
| _log.exception("Bad Request: %s", e) |
There was a problem hiding this comment.
Sorry, but this seems incorrect to me -- Logger.exception normally does not need to take the exception object, because that's pulled automatically from the handling context. Doesn't this lead to duplicate exception messages?
There was a problem hiding this comment.
But it does require an argument. Or do you mean removing this line here and just letting error handler handle later?
There was a problem hiding this comment.
No, he's saying:
_log.exception("Bad request")instead.
For example if you include the exception string:
WARNING:test:Message one
ERROR:test:Bad code: Message 2
Traceback (most recent call last):
File "/Users/timj/work/lsstsw/build/daf_butler/y.py", line 9, in <module>
raise RuntimeError("Message 2")
RuntimeError: Message 2
Finish
so you get "Message 2" in the first line of the log output and the final line of the output.
There was a problem hiding this comment.
I see. Thank you for explaining.
New PR: #214
Would one of you review please?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.