DM-44751: Add mypy check as required GHA before merging

.github/workflows/mypy_check.yaml

@@ -0,0 +1,14 @@
+name: Run mypy
+
+on:
+  push:
+    branches:
+      - main
+  pull_request:
+
+jobs:
+  call-workflow:
+    uses: lsst/rubin_workflows/.github/workflows/mypy.yaml@main
+    with:
+      # https://github.com/python/mypy/issues/17002
+      mypy_package: mypy!=1.9.0

mypy.ini

@@ -4,14 +4,17 @@ warn_unused_configs = False
 warn_redundant_casts = False
 plugins = pydantic.mypy
 
+[mypy-requests.*]
+ignore_missing_imports = True
+
 [mypy-astropy.*]
 ignore_missing_imports = True
 
 [mypy-erfa.*]
 ignore_missing_imports = True
 
 [mypy-numpy.*]
-ignore_missing_imports = True
+ignore_missing_imports = False
 
 [mypy-pandas.*]
 ignore_missing_imports = True
@@ -38,7 +41,10 @@ ignore_missing_imports = True
 ignore_missing_imports = True
 [mypy-tqdm.*]
 ignore_missing_imports = True
-
+[mypy-dateutil.*]
+ignore_missing_imports = True
+[mypy-deprecated.sphinx.*]
+ignore_missing_imports = True
 # Don't check LSST packages generally or even try to import them, since most
 # don't have type annotations.
 
@@ -51,31 +57,24 @@ ignore_errors = True
 # files with their own exceptions.
 
 [mypy-lsst.utils.*]
-ignore_missing_imports = False
 ignore_errors = True
 
 [mypy-lsst.resources.*]
-ignore_missing_imports = False
 ignore_errors = True
 
 [mypy-lsst.daf.relation.*]
-ignore_missing_imports = False
 ignore_errors = True
 
 [mypy-lsst.daf.butler.*]
-ignore_missing_imports = False
 ignore_errors = True
 
 [mypy-lsst.obs.base.*]
-ignore_missing_imports = False
 ignore_errors = True
 
 [mypy-lsst.pipe.base.*]
-ignore_missing_imports = False
 ignore_errors = True
 
 [mypy-lsst.pex.config.*]
-ignore_missing_imports = False
 ignore_errors = True
 
 [mypy-config.*]
@@ -86,11 +85,11 @@ ignore_errors = True
 
 # Check all of summit_utils...
 [mypy-lsst.summit.utils.*]
-ignore_missing_imports = False
+ignore_missing_imports = True
 ignore_errors = False
 disallow_untyped_defs = False
 disallow_incomplete_defs = False
-strict_equality = False
+strict_equality = True
 warn_unreachable = False
 warn_unused_ignores = False
 allow_untyped_globals = True

python/lsst/summit/utils/nightReport.py

@@ -22,7 +22,7 @@
 import datetime
 import logging
 import pickle
-from collections.abc import Callable, Iterable
+from collections.abc import Iterable
 from dataclasses import dataclass
 from typing import Any
 
@@ -40,15 +40,14 @@
 from .utils import getFieldNameAndTileNumber, obsInfoToDict
 
 try:  # TODO: Remove post RFC-896: add humanize to rubin-env
-    precisedelta: "Callable[[Any], str]"
     from humanize.time import precisedelta
 
     HAVE_HUMANIZE = True
 except ImportError:
     # log a python warning about the lack of humanize
     logging.warning("humanize not available, install it to get better time printing")
     HAVE_HUMANIZE = False
-    precisedelta = repr
+    precisedelta = repr  # type: ignore
 
 
 __all__ = ["NightReport"]
@@ -453,7 +452,7 @@ def printShutterTimes(self) -> None:
         sciEff = 100 * (timings["scienceTimeTotal"] / timings["nightLength"])
         print(f"Science shutter efficiency = {sciEff:.1f}%")
 
-    def getTimeDeltas(self) -> dict[int, float]:
+    def getTimeDeltas(self) -> dict[int, int]:
         """Returns a dict, keyed by seqNum, of the time since the end of the
         last integration. The time since does include the readout, so is always
         greater than or equal to the readout time.

python/lsst/summit/utils/quickLook.py

@@ -72,7 +72,9 @@ def __init__(self, *, config: Any = None):
         self.outputExposure = exposure
 
 
-class QuickLookIsrTaskConfig(pipeBase.PipelineTaskConfig, pipelineConnections=QuickLookIsrTaskConnections):
+class QuickLookIsrTaskConfig(
+    pipeBase.PipelineTaskConfig, pipelineConnections=QuickLookIsrTaskConnections  # type: ignore
+):
     """Configuration parameters for QuickLookIsrTask."""
 
     doRepairCosmics: pexConfig.Field[bool] = pexConfig.Field(

python/lsst/summit/utils/utils.py

@@ -1157,7 +1157,7 @@ def bboxToMatplotlibRectanle(bbox: geom.Box2I | geom.Box2D) -> matplotlib.patche
     return Rectangle(ll, width, height)
 
 
-def computeExposureId(instrument: str, controller: str, dayObs: int, seqNum) -> int:
+def computeExposureId(instrument: str, controller: str, dayObs: int, seqNum: int) -> int:
     instrument = instrument.lower()
     if instrument == "latiss":
         return lsst.obs.lsst.translators.LatissTranslator.compute_exposure_id(dayObs, seqNum, controller)

types.txt

@@ -0,0 +1,5 @@
+pydantic
+numpy
+matplotlib
+astro-metadata-translator
+humanize