DM-40101: Use vcr to provide a mock EFD for testing #55
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mfisherlevine
force-pushed
the
tickets/DM-40101
branch
from
4c2157f
to
4791feb
Compare
hsinfang
reviewed
Jul 19, 2023
tests/test_efdUtils.py
Outdated
| @@ -51,12 +54,24 @@ | |||
| except ImportError: | |||
| HAS_EFD_CLIENT = False | |||
|
|
|||
| # Use mode="none" to run tests for normal operation. | |||
| # To update files or generate new ones, make sure you have a working | |||
| # connection to lsst-schema-registry-efd.ncsa.illinois.edu | |||
There was a problem hiding this comment.
Is this address true? I'm a bit surprised to still see nasa dependency.
There was a problem hiding this comment.
Oh nvm... I see you corrected this in a later commit. I guess that commit could be squashed with the first one.
hsinfang
approved these changes
Jul 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.