DM-34340: Adapt to daf_butler API changes. #68
Conversation
|
@TallJimbo The Jira ticket is closed that is associated with this PR so is this PR still needed (I think so) or should it be closed? |
|
Oof, yes, this ticket definitely needs to get merged now. I vaguely remember passing the responsibility of merging it off to @mfisherlevine for some reason that I now forget, but we probably miscommunicated. I'll rebase and merge along with DM-41326 (merge is now in progress, and will have already broken this). Good catch! |
TallJimbo
force-pushed
the
tickets/DM-34340
branch
from
d40ea82
to
a0f5ca4
Compare
|
Ok, good news is that the adaptations to the deprecations seem to have already been made on other tickets. After rebase I think there's still stuff worth keeping on this ticket, so my plan is to finish the rest of the DM-41326 merge, then run a another ci_summit Jenkins with this before merging it. |
|
Accidentally closed due to git mistakes. Reopening. |
TallJimbo
force-pushed
the
tickets/DM-34340
branch
from
f073ad5
to
f3b603d
Compare
In my env, axvspan still returns Polygon, but in GitHub actions it's apparently Rectangle. Both inherit from Patch, and that is sufficient for downstream code.
|
I was also trying to fix the matplotlib mypy on #116 so thanks for this. I was considering pinning matplotlib version. |
No description provided.