DM-41664: Rename prompt_prototype package and containers #2724
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
hsinfang
approved these changes
Nov 14, 2023
applications/prompt-proto-service-latiss/values-usdfdev-prompt-processing.yaml
Show resolved
Hide resolved
The $RUBIN_INSTRUMENT variable is defined in the Helm template (Kubernetes config). Its use in the pipelines config is a holdover from the pre-Helm setup, when it reduced the amount of code that needed to be edited to switch instruments. With the Phalanx setup, all it does is introduce a (conceptual) circular dependency from the values file back to the template.
The package is now called prompt_processing.
The old prompt-proto-service containers are being phased out in favor of the shorter name. This commit drops the override for latiss-usdfprod entirely, as it's extremely unlikely that we'd want to use a nonstandard container in production (but this is kept as a useful hook for usdfdev).
kfindeisen
force-pushed
the
tickets/DM-41664
branch
from
142b1f3
to
ccdda9f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the Phanalx configuration for
prompt-proto-service-*to point to the new package name and the new container names. It makes no attempt to rename the service itself (deferred to DM-41665).This PR should be merged after lsst-dm/prompt_processing#96, though most of the changes that affect this PR are already visible.