Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add error fields to catalog schema #86

Open
wants to merge 1 commit into
base: prod
Choose a base branch
from
Open

Add error fields to catalog schema #86

wants to merge 1 commit into from

Conversation

isullivan
Copy link
Collaborator

Probably fixes the warning.

@isullivan isullivan requested a review from frossie September 12, 2024 23:02
@review-notebook-app Review Notebook App
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.

Powered by ReviewNB

@frossie
Copy link
Member

frossie commented Sep 13, 2024

I may be doing something wrong but I think it's still broken? (cells 53 and 67)

it does have the
from lsst.afw.table import SourceTable, SourceCatalog, CoordKey
line so I am reasonably sure I am not having a senior moment and running off this branch.

Screenshot of Safari at Sep 12, 2024 at 21_08_12

@isullivan
Copy link
Collaborator Author

I ran the notebook and found I needed to add the CoordKey line in another place. That should now be actually fixed.
I was surprised to find I had a read-only copy of this repository in my ~/notebooks directory. Is that expected?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@frossie frossie Awaiting requested review from frossie

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@isullivan @frossie