Add bending mode stress safety checks #79
Conversation
python/lsst/ts/mtaos/model.py
Outdated
| @@ -373,6 +386,26 @@ def get_dof_lv(self): | |||
|
|
|||
| return self.ofc.lv_dof | |||
|
|
|||
| def get_bending_mode_stresses(self): | |||
There was a problem hiding this comment.
Please, consider splitting this up into 2 methods, one for m2 and one for m1m3?
python/lsst/ts/mtaos/model.py
Outdated
| m1m3_bending_mode = BendingMode("M1M3", self.ofc.ofc_data) | ||
|
|
||
| m1m3_stresses = m1m3_bending_mode.stresses( | ||
| self.ofc.controller.aggregated_state[10:30] |
There was a problem hiding this comment.
I think these ranges (10-30) are set somewhere in the OFC configuration no?
python/lsst/ts/mtaos/model.py
Outdated
| self.ofc.controller.aggregated_state[10:30] | ||
| ) | ||
| m2_stresses = m2_bending_mode.stresses( | ||
| self.ofc.controller.aggregated_state[30:] |
There was a problem hiding this comment.
Same as above, I think these ranges are somewhere in ofc no?
python/lsst/ts/mtaos/mtaos.py
Outdated
|
|
||
| self._logExecFunc() | ||
|
|
||
| stressesM1M3, stressesM2 = self.model.bending_mode_stresses() |
python/lsst/ts/mtaos/mtaos.py
Outdated
| stressesM1M3, stressesM2 = self.model.bending_mode_stresses() | ||
|
|
||
| # Calculate the total stress on the mirror | ||
| stressM1M3 = self.stress_scale_factor * np.sqrt(np.sum(np.square(stressesM1M3))) |
tests/test_mtaosCsc.py
Outdated
| @@ -604,6 +618,70 @@ async def test_interruptWEP(self): | |||
| with self.assertRaises(salobj.AckError): | |||
| await run_wep_task | |||
|
|
|||
| def test_stress_below_limit(self): | |||
There was a problem hiding this comment.
It doesn't look like the next couple tests belongs here, or, at least, they need some work.
This file here contains tests for the CSC so we should make sure we create an instance of the CSC and we manipulate the CSC to test some behavior. This starts by adding
async with self.make_csc(
initial_state=salobj.State.STANDBY,
config_dir=TEST_CONFIG_DIR,
simulation_mode=0,
):
...
Then, you want to send a command to the CSC that would test the behavior you want. We now have the offsetDoF which probably can be used for what you want here.
it will look something like:
await self.remote.cmd_offsetDof.set_start(value=dof_aggr, timeout=STD_TIMEOUT)
Then you need to check the evens that where published as a result
dof = await self.assert_next_sample(self.remote.evt_degreeOfFreedom)
...
No description provided.