Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DM-44744: Catch numpy.linalg.LinAlgError in Gaussian KDE #288

Merged
merged 1 commit into from
Sep 24, 2024

Conversation

jtmccann
Copy link
Contributor

No description provided.

Copy link
Member

@arunkannawadi arunkannawadi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Just a minor suggestion to add a blank line between the two try-except blocks.

try:
zUsed = scipy.stats.gaussian_kde(xyUsed)(xyUsed)
except np.linalg.LinAlgError:
zUsed = np.ones(np.sum(fitPoints))
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
zUsed = np.ones(np.sum(fitPoints))
zUsed = np.ones(np.sum(fitPoints))

@jtmccann jtmccann merged commit a8628d9 into main Sep 24, 2024
8 checks passed
@jtmccann jtmccann deleted the tickets/DM-44744 branch September 24, 2024 19:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants