Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DM-46684: Add Metrics to calibrateImage task metadata #294

Merged
merged 4 commits into from
Oct 18, 2024

Conversation

jrmullaney
Copy link
Contributor

No description provided.

@jrmullaney jrmullaney force-pushed the tickets/DM-46684 branch 3 times, most recently from 543624c to db3234c Compare October 16, 2024 22:23
Copy link
Contributor

@isullivan isullivan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, but please take the Calexp metric names to #dm-naming-things to get broader feedback on those names.

pipelines/visitQualityCore.yaml Show resolved Hide resolved
pipelines/calexpMetrics.yaml Show resolved Hide resolved
Enables metrics to be renamed from how they are referred
to in metadata, and allows multiple subtask metadatas to
be searched for metrics.
Added to visitQualityCore
@jrmullaney jrmullaney force-pushed the tickets/DM-46684 branch 7 times, most recently from 0f8e2f5 to 3ebe8bc Compare October 18, 2024 07:58
calexpMetrics.yaml doesn't comply with the *Core.yaml/
*Extended.yaml convention of other analysis tools
pipeline tasks. Since its contents produce visit-level
metrics, visitQualityCore.yaml is a better home for tasks
that analyze outputs from calibrateTask. pviMetrics.yaml
has been created to temporarily hold tasks that will
analyze data from calibrateImageTask.
To work with newly-configured MetadataMetricTool
@jrmullaney jrmullaney merged commit 0b3296b into main Oct 18, 2024
8 checks passed
@jrmullaney jrmullaney deleted the tickets/DM-46684 branch October 18, 2024 21:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants