DM-46918: Updates to use the_monster as a refcat #298
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
erykoff
reviewed
Oct 21, 2024
| @@ -84,6 +84,8 @@ def runQuantum(self, butlerQC, inputRefs, outputRefs): | |||
| # the HSC ones do, this is a bit hacky but fixes this | |||
| if bands[0].startswith("lsst") or "sim" in bands[0] or "smeared" in bands[0]: | |||
| bands = self.config.filterNames | |||
| elif bands[0].startswith("monster"): | |||
| bands = [band[-1] for band in bands] | |||
There was a problem hiding this comment.
Why the -1? I don't fully follow this code (or why everything is so hacked up...)
There was a problem hiding this comment.
I added some more documentation, is this enough?
There was a problem hiding this comment.
Ah that helps. This is ticketed to fix this correctly, right? And fortunately we only have one character bands in the monster (maybe worth mentioning that we don't support NB in the monster).
There was a problem hiding this comment.
Added the ticket number to fix this
erykoff
approved these changes
Oct 21, 2024
psferguson
force-pushed
the
tickets/DM-46918
branch
from
83e5e13
to
a834c18
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.