Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DM-36968: Make per-tract survey property map plots #93

Merged
merged 1 commit into from
Oct 13, 2023
Merged

DM-36968: Make per-tract survey property map plots #93

merged 1 commit into from
Oct 13, 2023

Conversation

enourbakhsh
Copy link
Contributor

No description provided.

@enourbakhsh enourbakhsh force-pushed the tickets/DM-36968 branch 7 times, most recently from 94d16ee to 5e48e5f Compare September 22, 2023 20:44
@enourbakhsh enourbakhsh force-pushed the tickets/DM-36968 branch 5 times, most recently from 507e613 to 0f538bc Compare September 26, 2023 23:22
erykoff
erykoff reviewed Sep 27, 2023
View reviewed changes
Copy link
Contributor

@erykoff erykoff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A bunch of small comments here, and one big one: how is this tested?

python/lsst/analysis/tools/actions/plot/propertyMapPlot.py Outdated Show resolved Hide resolved
python/lsst/analysis/tools/actions/plot/propertyMapPlot.py Outdated Show resolved Hide resolved
python/lsst/analysis/tools/actions/plot/propertyMapPlot.py Outdated Show resolved Hide resolved
python/lsst/analysis/tools/actions/plot/propertyMapPlot.py Outdated Show resolved Hide resolved
python/lsst/analysis/tools/actions/plot/propertyMapPlot.py Outdated Show resolved Hide resolved
python/lsst/analysis/tools/actions/plot/propertyMapPlot.py Outdated Show resolved Hide resolved
python/lsst/analysis/tools/actions/plot/propertyMapPlot.py Outdated Show resolved Hide resolved
python/lsst/analysis/tools/actions/plot/propertyMapPlot.py Show resolved Hide resolved
python/lsst/analysis/tools/tasks/propertyMapTractAnalysis.py Outdated Show resolved Hide resolved
python/lsst/analysis/tools/tasks/propertyMapTractAnalysis.py Show resolved Hide resolved
@enourbakhsh
Copy link
Contributor Author

A bunch of small comments here, and one big one: how is this tested?

I've incorporated a plotPropertyMapTractExtended task into analysis_tools/pipelines/coaddQualityExtended.yaml. It'll be executed as part of ci_hsc via this line. Does that cover it?

@enourbakhsh enourbakhsh force-pushed the tickets/DM-36968 branch 2 times, most recently from da5e028 to c329033 Compare September 29, 2023 01:30
@enourbakhsh enourbakhsh force-pushed the tickets/DM-36968 branch 3 times, most recently from d08b660 to 25ac619 Compare October 12, 2023 20:05
@enourbakhsh
Copy link
Contributor Author

enourbakhsh commented Oct 12, 2023 •
edited
Loading

A bunch of small comments here, and one big one: how is this tested?

I've incorporated a plotPropertyMapTractExtended task into analysis_tools/pipelines/coaddQualityExtended.yaml. It'll be executed as part of ci_hsc via this line. Does that cover it?

Now, all the maps are housed in the coaddQualityCore.yaml pipeline. They are set to undergo testing in ci_hsc via $DRP_PIPE_DIR/pipelines/_ingredients/HSC/DRP.yaml found in $DRP_PIPE_DIR/pipelines/HSC/DRP-ci_hsc.yaml.

@enourbakhsh enourbakhsh merged commit 60f6099 into main Oct 13, 2023
8 checks passed
@enourbakhsh enourbakhsh deleted the tickets/DM-36968 branch October 13, 2023 05:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@erykoff erykoff erykoff approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@enourbakhsh @erykoff