Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DM-48094: Fix dataset fields not working in Butler.query_datasets #1133

Merged
merged 1 commit into from
Dec 12, 2024

Conversation

dhirving
Copy link
Contributor

@dhirving dhirving commented Dec 11, 2024

Fix an issue where dataset fields like ingest_date were raising InvalidQueryError: Unrecognized identifier because the where clause was being applied before query was known to be a dataset query.

Checklist

  • ran Jenkins
  • added a release note for user-visible changes to doc/changes
  • (if changing dimensions.yaml) make a copy of dimensions.yaml in configs/old_dimensions

Copy link

codecov bot commented Dec 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.49%. Comparing base (36ed777) to head (3af7307).
Report is 2 commits behind head on main.

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1133   +/-   ##
=======================================
  Coverage   89.49%   89.49%           
=======================================
  Files         366      366           
  Lines       48801    48805    +4     
  Branches     5900     5900           
=======================================
+ Hits        43676    43680    +4     
  Misses       3718     3718           
  Partials     1407     1407           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Fix an issue where dataset fields like `ingest_date` were raising `InvalidQueryError: Unrecognized identifier` because the where clause was being applied before query was known to be a dataset query.
@dhirving dhirving merged commit 8636101 into main Dec 12, 2024
19 checks passed
@dhirving dhirving deleted the tickets/DM-48094 branch December 12, 2024 23:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants