DM-48288: Do not enable caching context by default in queries #1138
+75
−67
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We no longer implicitly enable the caching context by default when entering the Butler.query() context manager. More often than not, the context manager is used to execute one query and then exited. The cache is often a pessimization in this common case -- notably the collection summary cache was often fetching tens of thousands of records when only a few were needed.
Added explicit caching context enables in a few places that were previously benefitting from caching being enabled by default.
Checklist
doc/changes
configs/old_dimensions