Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DM-41562: Rewrite much of DatasetRef.from_simple to fix cache problem. #902

Merged
merged 1 commit into from
Nov 8, 2023

Rewrite much of DatasetRef.from_simple to fix cache problem.

4130889
Select commit
Loading
Failed to load commit list.
Merged

DM-41562: Rewrite much of DatasetRef.from_simple to fix cache problem. #902

Rewrite much of DatasetRef.from_simple to fix cache problem.
4130889
Select commit
Loading
Failed to load commit list.
This check has been archived and is scheduled for deletion. Learn more about checks retention
Codecov / codecov/project failed Nov 8, 2023 in 0s

87.86% (-0.02%) compared to 60026e2

View this Pull Request on Codecov

87.86% (-0.02%) compared to 60026e2

Details

Codecov Report

Attention: 27 lines in your changes are missing coverage. Please review.

Comparison is base (60026e2) 87.87% compared to head (4130889) 87.86%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #902      +/-   ##
==========================================
- Coverage   87.87%   87.86%   -0.02%     
==========================================
  Files         281      281              
  Lines       36435    36440       +5     
  Branches     7601     7604       +3     
==========================================
- Hits        32019    32017       -2     
- Misses       3263     3273      +10     
+ Partials     1153     1150       -3     
Files Coverage Δ
python/lsst/daf/butler/persistence_context.py 59.25% <100.00%> (ø)
python/lsst/daf/butler/_dataset_ref.py 80.99% <25.00%> (-2.56%) ⬇️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.