DM-34332: Document ip_isr #243
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
czwa
force-pushed
the
tickets/DM-34332
branch
from
5d62587
to
a69acfa
Compare
timj
reviewed
Dec 2, 2022
python/lsst/ip/isr/ampOffset.py
Outdated
| @@ -27,9 +27,13 @@ | |||
| from lsst.meas.algorithms import (SubtractBackgroundTask, SourceDetectionTask) | |||
|
|
|||
|
|
|||
| __all__ = ['AmpOffsetConfig', 'AmpOffsetTask'] | |||
There was a problem hiding this comment.
Doesn't main already have this change (but with different quotes)?
There was a problem hiding this comment.
(Ah, I see that the main one is a few lines above this -- the __all__ should always be before the first import)
There was a problem hiding this comment.
It looks like the additions happened in parallel on different tickets, and I didn't notice in the diff because they're separated. I'll go through and clean up the extras throughout.
timj
reviewed
Dec 2, 2022
python/lsst/ip/isr/isrQa.py
Outdated
| @@ -27,6 +27,9 @@ | |||
| import lsst.pex.config as pexConfig | |||
|
|
|||
|
|
|||
| __all__ = ['IsrQaFlatnessConfig', 'IsrQaConfig', 'makeThumbnail'] | |||
There was a problem hiding this comment.
This one is also duplicating one that is higher up the file. I'll stop commenting about them now since you should be able to find ones that have multiple __all__ in a single file.
czwa
force-pushed
the
tickets/DM-34332
branch
from
f5dfc86
to
6f9cbc7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update ancient docstrings to modern format. Fix some remaining typos. Populate
doc/tree.