Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DM-40463-v25: Test is failing on macOS Ventura #33

Merged
merged 4 commits into from
Aug 24, 2023

Conversation

mwittgen
Copy link
Contributor

No description provided.

@mwittgen mwittgen changed the title DM-40463-v25: Gaap is failing on macOS Ventura DM-40463-v25: Test is failing on macOS Ventura Aug 24, 2023
Copy link
Member

@arunkannawadi arunkannawadi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In line 351, there should be a space after not. This is a change that Tim introduced in an earlier commit, which needs to be included for the linter to pass.

@timj
Copy link
Member

timj commented Aug 24, 2023

Commit a5bc7d8 I think.

@arunkannawadi
Copy link
Member

You beat me by 5 seconds.

@mwittgen mwittgen merged commit 982026f into v25.0.x Aug 24, 2023
1 check passed
@mwittgen mwittgen deleted the tickets/DM-40463-v25 branch August 24, 2023 22:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants