Merge pull request #804 from lsst/tickets/DM-34496

DM-34496: Remove already-deprecated fake-source insertion interfaces
lsst · Jun 29, 2023 · 2e59211 · 2e59211
2 parents 14b43e0 + abf9156
commit 2e59211
Show file tree

Hide file tree

Showing 4 changed files with 0 additions and 131 deletions.
diff --git a/doc/lsst.pipe.tasks/tasks/lsst.pipe.tasks.fakes.BaseFakeSourcesTask.rst b/doc/lsst.pipe.tasks/tasks/lsst.pipe.tasks.fakes.BaseFakeSourcesTask.rst
diff --git a/python/lsst/pipe/tasks/calibrate.py b/python/lsst/pipe/tasks/calibrate.py
@@ -44,7 +44,6 @@
 from lsst.meas.deblender import SourceDeblendTask
 from lsst.utils.timer import timeMethod
 from lsst.pipe.tasks.setPrimaryFlags import SetPrimaryFlagsTask
-from .fakes import BaseFakeSourcesTask
 from .photoCal import PhotoCalTask
 from .computeExposureSummaryStats import ComputeExposureSummaryStatsTask
 
@@ -286,20 +285,6 @@ class CalibrateConfig(pipeBase.PipelineTaskConfig, pipelineConnections=Calibrate
         target=CatalogCalculationTask,
         doc="Subtask to run catalogCalculation plugins on catalog"
     )
-    doInsertFakes = pexConfig.Field(
-        dtype=bool,
-        default=False,
-        doc="Run fake sources injection task",
-        deprecated=("doInsertFakes is no longer supported. This config will be removed after v24. "
-                    "Please use ProcessCcdWithFakesTask instead.")
-    )
-    insertFakes = pexConfig.ConfigurableField(
-        target=BaseFakeSourcesTask,
-        doc="Injection of fake sources for testing purposes (must be "
-            "retargeted)",
-        deprecated=("insertFakes is no longer supported. This config will be removed after v24. "
-                    "Please use ProcessCcdWithFakesTask instead.")
-    )
     doComputeSummaryStats = pexConfig.Field(
         dtype=bool,
         default=True,

diff --git a/python/lsst/pipe/tasks/fakes.py b/python/lsst/pipe/tasks/fakes.py
diff --git a/python/lsst/pipe/tasks/multiBand.py b/python/lsst/pipe/tasks/multiBand.py
@@ -34,7 +34,6 @@
     SkyMapIdGeneratorConfig,
 )
 from lsst.meas.astrom import DirectMatchTask, denormalizeMatches
-from lsst.pipe.tasks.fakes import BaseFakeSourcesTask
 from lsst.pipe.tasks.setPrimaryFlags import SetPrimaryFlagsTask
 from lsst.pipe.tasks.propagateSourceFlags import PropagateSourceFlagsTask
 import lsst.afw.table as afwTable
@@ -109,15 +108,6 @@ class DetectCoaddSourcesConfig(PipelineTaskConfig, pipelineConnections=DetectCoa
     scaleVariance = ConfigurableField(target=ScaleVarianceTask, doc="Variance rescaling")
     detection = ConfigurableField(target=DynamicDetectionTask, doc="Source detection")
     coaddName = Field(dtype=str, default="deep", doc="Name of coadd")
-    doInsertFakes = Field(dtype=bool, default=False,
-                          doc="Run fake sources injection task",
-                          deprecated=("doInsertFakes is no longer supported. This config will be removed "
-                                      "after v24."))
-    insertFakes = ConfigurableField(target=BaseFakeSourcesTask,
-                                    doc="Injection of fake sources for testing "
-                                    "purposes (must be retargeted)",
-                                    deprecated=("insertFakes is no longer supported. This config will "
-                                                "be removed after v24."))
     hasFakes = Field(
         dtype=bool,
         default=False,