Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DM-39840: Deprecate doPsfMatch field in coaddBase #806

Merged
merged 2 commits into from
Jun 30, 2023
Merged

DM-39840: Deprecate doPsfMatch field in coaddBase #806

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0ec6c26
Deprecate doPsfMatch
arunkannawadi Jun 29, 2023
3770491
Add TODO comments referencing removal ticket
arunkannawadi Jun 29, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion python/lsst/pipe/tasks/assembleCoadd.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -244,7 +244,7 @@ def setDefaults(self):

def validate(self):
super().validate()
if self.doPsfMatch:
if self.doPsfMatch: # TODO: Remove this in DM-39841
# Backwards compatibility.
# Configs do not have loggers
log.warning("Config doPsfMatch deprecated. Setting warpType='psfMatched'")
Expand Down
3 changes: 2 additions & 1 deletion python/lsst/pipe/tasks/coaddBase.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,7 +57,8 @@ class CoaddBaseConfig(pexConfig.Config):
)
doPsfMatch = pexConfig.Field(
dtype=bool,
doc="Match to modelPsf? Deprecated. Sets makePsfMatched=True, makeDirect=False",
doc="Match to modelPsf? Sets makePsfMatched=True, makeDirect=False",
deprecated="This field is no longer used. Will be removed after v27.", # TODO: DM-39841
default=False
)
modelPsf = measAlg.GaussianPsfFactory.makeField(doc="Model Psf factory")
Expand Down
2 changes: 1 addition & 1 deletion python/lsst/pipe/tasks/makeWarp.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -244,7 +244,7 @@ def validate(self):

if not self.makePsfMatched and not self.makeDirect:
raise RuntimeError("At least one of config.makePsfMatched and config.makeDirect must be True")
if self.doPsfMatch:
if self.doPsfMatch: # TODO: Remove this in DM-39841
# Backwards compatibility.
log.warning("Config doPsfMatch deprecated. Setting makePsfMatched=True and makeDirect=False")
self.makePsfMatched = True
Expand Down