-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DM-38703: Add missing bright star feature to subtractBrightStars #815
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Broadly speaking, the logic in these changes appears fine in terms of how the functions are split up, named and called (I'm assuming they've been tested elsewhere). However, I think they would benefit greatly from a few judiciously-placed comments to explain the logic and flow. I have a half-remembered idea of how this task was supposed to work from the last time Morgan talked about it but it's not quite enough for me to piece together exactly what's happening at each stage.
002c926
to
e3582c4
Compare
05c86e3
to
b30a4a1
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some further suggestions/comments.
@bazkiaei for your next review, please have a look at https://developer.lsst.io/work/flow.html#using-github-pull-requests and especially note the recommendation to use emoji reactions for minor fixes that do not require discussion.
63650a3
to
bfa2a5f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few more nitpicks.
caa6f40
to
8d0a339
Compare
8d0a339
to
f2254f6
Compare
No description provided.