DM-42979: Use calibFlux for source selector #983
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
parejkoj
reviewed
Sep 27, 2024
Comment on lines
374
to
375
| self.star_selector["science"].signalToNoise.fluxField = "slot_CalibFlux_instFlux" | ||
| self.star_selector["science"].signalToNoise.errField = "slot_CalibFlux_instFluxErr" |
There was a problem hiding this comment.
What was the default for these? I would have thought that CalibFlux was the default, but ScienceSourceSelector defaults to PsfFlux. That surprises me, and I wonder if we have other places that have been inadvertently using the wrong flux?
Although, you shouldn't have a negative flux if we're restricting to S/N>10, since N is always positive, no?
There was a problem hiding this comment.
These defaulted to PsfFlux, and none of the later source selectors apply a N/N cut. They all assume that has been taken care of by this first selector, so if a source with valid PsfFlux but negative CalibFlux makes it through this selection it gets used for photometry.
abudlong
force-pushed
the
tickets/DM-42979
branch
from
db843b0
to
517812e
Compare
abudlong
force-pushed
the
tickets/DM-42979
branch
from
517812e
to
3e1e105
Compare
abudlong
force-pushed
the
tickets/DM-42979
branch
2 times, most recently
from
224260c
to
d116f3b
Compare
This ensures that the flux used in photometric calibration is a valid value. Otherwise the PsfFlux is used for selection and slot_CalibFlux is used for calibration.
abudlong
force-pushed
the
tickets/DM-42979
branch
from
d116f3b
to
03f5e07
Compare
isullivan
approved these changes
Nov 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.